Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Mollie payments that don't require interaction (follow-up payments) asynchronous? #255

Closed
remcotolsma opened this issue Oct 14, 2021 · 3 comments

Comments

@remcotolsma
Copy link
Member

remcotolsma commented Oct 14, 2021

https://github.com/wp-pay-gateways/mollie/blob/a65e919f6228483c5672be6bdfdb3ae64342975f/src/Gateway.php#L463-L464

When we make these create payment requests asynchronous it's easier to retry them?

Code Description
429 Too Many Requests – Your request has hit a rate limit. Please wait for a bit and retry.

https://docs.mollie.com/overview/handling-errors

I also mentioned Mollie error handling als in this issue: #188 (comment).

The follow-up payments that could not be started could be put in a queue.

Maybe https://actionscheduler.org/ (#253) can help us to make it easier to reschedule those actions.

@rvdsteege
Copy link
Member

@remcotolsma
Copy link
Member Author

We have (partly) implemented this in https://github.com/wp-pay-gateways/mollie/blob/19a60e2d5ad3ee8ca7466f0cad78d666d59179d1/src/Gateway.php#L450-L494. In case of exceptions in checking/creating a Mollie user or mandate, there may still be room for improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants