Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include digital and physical products in {payment_lines_name} merge tag #184

Closed
rvdsteege opened this issue Jun 6, 2024 · 1 comment
Assignees

Comments

@rvdsteege
Copy link
Member

I just added the {payment_lines_name} to the description of a WooCommerce setting in https://github.com/pronamic/pronamic-pay/issues/100 and noticed that this tag includes payment lines of all types — including discounts, fees, shipping and taxes. I think we're not interested in these types in payment descriptions?

For example, the payment description of a WooCommerce order now results in (where 'Vast Tarief' refers to shipping costs):

Bestelling {order_number} voor {payment_lines_name}
Bestelling 43801 voor Simple product, Vast Tarief

https://github.com/pronamic/wp-pay-core/blob/dc45e1a5241205af4de0eca6a84f79a655c50411/src/Payments/PaymentLineType.php

@remcotolsma
Copy link
Member

One user will like it, another will not. I don't think it has been used enough yet to make a good choice. It can be useful for a seller if they sell product A and the customer can choose from different shipping methods (pick up at the online store, normal via PostNL, urgent via courier) this can now be visible in the description for both the customer and the seller. I'm leaning more towards simplicity in the code for now. Wait and see if Pronamic Pay users will stumble over this?

@remcotolsma remcotolsma closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Pronamic Pay Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants