-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jmxexporter adding incorrect _total suffix to #HELP and #TYPE when using COUNTER #968
Comments
Is this still the case with |
@fstab, Using jmxexporter 0.20.0 as 1.x says |
I have been google around and I guess the |
@dhoard time to release 1.0.1, this should fix it :) |
The client_java documetation says
But in anycase jmxexporter should either produce
or
but not what's producing now, mixing |
yes, it does fix it.. I tried with main 2797571 and when I specify
the metric name get rewritten to so yes, it does fix it. @fstab @dhoard , I suggest to mention in the docs for rules > name something like
to help people that are not familiar with the _total suffix to discover it. (Specially since Then one question remains can I force jmxexporter to output |
@ecerulm I added the documentation change above and am in the process of publishing the 1.0.1 release. |
@ecerulm release published. please test. |
It works , it adds the |
@ecerulm Thanks for the confirmation! |
I'm using a jmxrule to convert the
requestCount
from MBeanCatalina:name="http-nio-8033",type=GlobalRequestProcessor
toCOUNTER
and although the metric name is set to
catalina_globalrequestprocessor_requestcount
the# HELP
and# TYPE
refer tocatalina_globalrequestprocessor_requestcount_total
(note the_total
suffix at the end).So the result prometheus text format is
As far as I understand this is incorrect since the metric name is actually
catalina_globalrequestprocessor_requestcount
notcatalina_globalrequestprocessor_requestcount_total
. So the generated# HELP
and#TYPE
are really for different non-existing metric.Here is the jmxexporter configuration:
If I remove the
type: COUNTER
line then the prometheus text format generated will beIn this case the metrics name matches in all three lines (no
_total
anywhere) but theTYPE
is not counter like I wanted it to be.The text was updated successfully, but these errors were encountered: