Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector test failures #34

Open
spencergilbert opened this issue Jul 17, 2021 · 0 comments
Open

Vector test failures #34

spencergilbert opened this issue Jul 17, 2021 · 0 comments

Comments

@spencergilbert
Copy link

I started looking into the failures for Vector in my spare time and already found some things (planning on making a PR to resolve anything on this end when I have enough fixes in place).

Some of the errors (ex: missing headers) appear to be on the configuration side for Vector, updating https://github.com/prometheus/compliance/blob/main/remote_write/targets/vector.go#L38 to either have /push or /api/v1/write both seem to resolve the missing headers portion of the test - though I'm not sure why both paths work.

The Headers test still fails with this change with found zero samples for {__name__="now"} - however, if I update the Vector config to be:

[sources.prometheus_scrape]
  type = "prometheus_scrape"
  endpoints = ["http://%s/metrics"]
  scrape_interval_secs = 1

[sinks.prometheus_remote_write]
  type = "prometheus_remote_write"
  inputs = ["prometheus_scrape"]
  endpoint = "%s/api/v1/write"

[sinks.prometheus]
  type = "prometheus_remote_write"
  inputs = ["prometheus_scrape"]
  endpoint = "http://127.0.0.1:9090/api/v1/write"

And run prometheus locally:

docker run --rm -it -p 9090:9090 prom/prometheus --config.file=/etc/prometheus/prometheus.yml --enable-feature=remote-write-receiver

I am getting a result back when querying for {__name__="now"} - It's not immediately clear to me the difference between the test setup and the experimental implementation and can dig in more if y'all don't have a reason off the top of your head.

I'll keep working on the test setup (and any required changes on the Vector side) and update in this issue or on a draft PR, depending on your preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant