Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support descriptive names from JSON payload. #19

Open
tomprince opened this issue Sep 29, 2015 · 5 comments
Open

Support descriptive names from JSON payload. #19

tomprince opened this issue Sep 29, 2015 · 5 comments

Comments

@tomprince
Copy link

collectd knows what the various fields in a metric are, and passes them in the JSON. the exporter should use this information.

For example collectd_processes_ps_cputime_0 is user and ..._1 is syst.

@octo
Copy link
Contributor

octo commented Oct 1, 2015

Hi @tomprince, thanks for your input! Which version of the collectd Go library (collectd/go-collectd) are you currently using? Commit 292a66c should have implemented this feature:

if dsname := vl.DSName(index); dsname != "value" {
  name += "_" + dsname
}

@hasso
Copy link
Contributor

hasso commented Oct 14, 2015

I'm seeing the issue as well. I'm not using JSON though, but a binary network protocol.

@octo
Copy link
Contributor

octo commented Oct 14, 2015

@hasso the binary network protocol does not include this information, therefore it's impossible to derive it from the traffic itself. We might be able to support for types.db files though.

@hasso
Copy link
Contributor

hasso commented Oct 15, 2015

That what I was afraid of. Thanks.

@octo
Copy link
Contributor

octo commented Jul 27, 2016

FYI, collectd/go-collectd#17 implements the infrastructure required for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants