From 27fe3b733165230c4f5ae6f9bbf3242b095b8ad7 Mon Sep 17 00:00:00 2001
From: dhoard <doug.hoard@gmail.com>
Date: Sat, 5 Aug 2023 19:03:17 -0400
Subject: [PATCH] Changed to remove use of inefficient String method

Signed-off-by: dhoard <doug.hoard@gmail.com>
---
 .../prometheus/client/exporter/common/TextFormat.java  | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/simpleclient_common/src/main/java/io/prometheus/client/exporter/common/TextFormat.java b/simpleclient_common/src/main/java/io/prometheus/client/exporter/common/TextFormat.java
index db2de3a5b..58c0ebfa9 100644
--- a/simpleclient_common/src/main/java/io/prometheus/client/exporter/common/TextFormat.java
+++ b/simpleclient_common/src/main/java/io/prometheus/client/exporter/common/TextFormat.java
@@ -137,8 +137,9 @@ public static void write004(Writer writer, Enumeration<Collector.MetricFamilySam
   }
 
   private static void writeEscapedHelp(Writer writer, String s) throws IOException {
-    for (int i = 0; i < s.length(); i++) {
-      char c = s.charAt(i);
+    char[] characters = s.toCharArray();
+    for (int i = 0; i < characters.length; i++) {
+      char c = characters[i];
       switch (c) {
         case '\\':
           writer.append("\\\\");
@@ -153,8 +154,9 @@ private static void writeEscapedHelp(Writer writer, String s) throws IOException
   }
 
   private static void writeEscapedLabelValue(Writer writer, String s) throws IOException {
-    for (int i = 0; i < s.length(); i++) {
-      char c = s.charAt(i);
+    char[] characters = s.toCharArray();
+    for (int i = 0; i < characters.length; i++) {
+      char c = characters[i];
       switch (c) {
         case '\\':
           writer.append("\\\\");