-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request : md5 on a page #351
Comments
There's already regex support to verify that a http response contains given output, is this not sufficient for your use case? |
Regex feature is really cool (thanks for this) but it is not enough to verify the page is not changed, that's not the same thing to verify the integrity of a page like with a checksum. |
What are you actually trying to test here? The presumption is that you've got some form of web app whose content changes over time, so you want to look for e.g. key phrases rather than exact content which can change from release to release. |
Ok let's have some concretes examples :) |
Checking the integrity of an entire website is a bit out of scope, this exporter is more for determining if a website is working at all - and not something you want to be doing once a minute. A tool specifically designed for this may be better here. |
It might be an option to expose the sha256sum of the page an info metric. |
That could vary from scrape to scrape, and thus would be too high cardinality. |
Let's be clear: the feature is requested to validate an http web page not to check a site. |
I like that feature. You could even expose it just as metric value. I think it would be useful for monitoring all kind of assets for consistency. e.g use it to check if your public key on 3rd party service wasn't modified oder your shasum file for a binary release on a package mirror etc. |
@discordianfish absolutely |
I've taken a look into implementing this, and based on the comments I see the following options:
|
Why not SHA as metric value? That's what I would do. But it looks like @brian-brazil doesn't want it anyway so this issue should probably be closed. |
Because metric values are double-precision floating point (float64), and a SHA is >64 bits. 64 bits is not sufficient to ensure that the content has not been tampered with. This limitation is why I suggested CRC32 above. Concerning label values: this will result in high cardinality (see caution in the documentation), so it would need to be opt-in (and even then would not be a great idea). Play around with this branch if your really want to try it. |
A HTTP response does not have to be a text. It can be a binary data. In this case a regex will not work. And a content checksum seems to be a good idea for such data. In my case I want to check that a content of the dynamically generated PNG file does not change. Currently I can only check status code and content length. |
Why do you think that? What problems did you encounter? |
This approach would be a perfect fit for monitoring the integrity of security.txt files and PGP public keys linked from there. |
Yeah I still think this would be make a good feature. Now with Brian not being maintainer anymore, I think it's likely that this would get merged /cc @roidelapluie |
not exactly what's being asked here but we do we have |
Hi
All is in the title, this is a feature request for a new probe: md5 check to a specified value to verify the integrity of a page.
The text was updated successfully, but these errors were encountered: