Add hack scripts to test urls, update add-runbook #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for distracted-northcutt-e0bccc ready! 🔨 Explore the source changes: 6862dc7 🔍 Inspect the deploy log: https://app.netlify.com/sites/distracted-northcutt-e0bccc/deploys/620fef66c1b07f00080ac4b5 😎 Browse the preview: https://deploy-preview-12--distracted-northcutt-e0bccc.netlify.app |
paulfantom
reviewed
Feb 22, 2022
Comment on lines
+1
to
+27
| #!/usr/bin/env bash | ||
| # check urls via trying to connect to hugo server on localhost:1313 | ||
|
|
||
| rm -rf kps | ||
| git clone --depth 1 https://github.com/prometheus-community/helm-charts/ kps | ||
|
|
||
| URL_PATHS=$(grep -R "runbook_url:" kps/charts/kube-prometheus-stack | grep .yaml | awk '{print $5}' | tr -d "}" | sort | uniq) | ||
|
|
||
| ENDPOINT=${ENDPOINT:-"http://localhost:1313/runbooks"} | ||
|
|
||
| exit_code=0 | ||
| echo "Checking runbook urls... please wait" | ||
|
|
||
| for runbook in $URL_PATHS; do | ||
| if ! curl --output /dev/null --silent --head --fail "${ENDPOINT}${runbook}"; then | ||
| rule_file=$(grep -n -R "$runbook" kps/charts/kube-prometheus-stack | awk '{print $1}') | ||
| echo -e "Missing ${runbook} \n\t $EDITOR $rule_file" | ||
| exit_code=1 | ||
| fi | ||
| done | ||
|
|
||
| if [ $exit_code == 0 ]; then | ||
| echo "Great Success, no issues found!" | ||
| else | ||
| echo "Oh no, errors!" | ||
| fi | ||
| exit $exit_code |
There was a problem hiding this comment.
We are using mdox for this in kube-prometheus and prometheus-operator. I don't see any reason we shouldn't be using it here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.