Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling stats line - after update to rsyslog-8.2204 #10

Open
mvrk69 opened this issue Jan 25, 2023 · 10 comments · May be fixed by #11
Open

error handling stats line - after update to rsyslog-8.2204 #10

mvrk69 opened this issue Jan 25, 2023 · 10 comments · May be fixed by #11
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mvrk69
Copy link

mvrk69 commented Jan 25, 2023

Hi,

I updated my rsyslog to 8.2204 and started having this error messages from the exporter:

Jan 25 07:21:45 syslog002 rsyslog_exporter[2097]: 2023/01/25 15:21:45 error handling stats line: unknown pstat type: 0, line was: 2023-01-25T07:21:45.871761-08:00 syslog002 rsyslogd-pstats: { "name": "global", "origin": "percentile", "values": { } }

Do you know what could be the problem?

Best regards.

@matthiasr
Copy link

The code that determines the pstat type and decides what to do with it doesn't know what to do with this line. And frankly, neither do I, it does not seem to actually include any useful data. I think the error is benign (nothing of value is lost) but noisy, so it makes sense to handle this case.

@matthiasr matthiasr added enhancement New feature or request good first issue Good for newcomers labels Feb 10, 2023
@aleroyer
Copy link
Collaborator

Hi @mvrk69,

I can reproduce this also in 8.2112.

As @matthiasr suggested, worst case I will silent this message if no useful data comes from this pstat.

@aleroyer
Copy link
Collaborator

aleroyer commented Feb 13, 2023

Did a bit of research:

  • The stat is pushed by default since 8.2112 (I don't have it in 8.2102);
  • It is empty by default (like the dynstat one) if you are not using percentile stats feature;
  • It seems to be really similar to dynstat pstat (need more testing);

I will see how to implement it.

@aleroyer aleroyer linked a pull request Feb 18, 2023 that will close this issue
@autokilla47
Copy link

waiting for a new version of the exporter?

@aleroyer
Copy link
Collaborator

waiting for a new version of the exporter?

For the moment, this PR #7 can be used as a workaround to silence those errors messages.
You need to pull/build from master.

@vilhelmprytz
Copy link

Sorry to ping people in this issue after almost a year of no activity.

@aleroyer Would it be possible to create a new release of this exporter to include the changes from #7? Or are we waiting for #11 before new release?

@aleroyer
Copy link
Collaborator

@aleroyer Would it be possible to create a new release of this exporter to include the changes from #7? Or are we waiting for #11 before new release?

I will make a new release so we can at least hide those messages.

I haven't had time to dedicate into refactoring some stuff in the exporter to finish #11 properly.

@grzesrap
Copy link

please proceed with new release

@vilhelmprytz
Copy link

@aleroyer Understandable, thanks for answering! I wouldn't mind multiple smaller releases if that makes it easier!

@aleroyer
Copy link
Collaborator

aleroyer commented Mar 7, 2024

@grzesrap @vilhelmprytz 1.1.0 released.

I had to fix github actions to make it work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants