Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow client to scrape a custom target while advertising a different FQDN #81

Open
mcastellini opened this issue Jun 12, 2020 · 1 comment

Comments

@mcastellini
Copy link

In some situations I have encoutered it would be very helpful to advertise a given FQDN while targeting a hostname different from such FQDN.

One situation in which I would find this quite helpful is having to scrape multiple environment through a common PushProx proxy instance. If those environments are basically clones (e.g.: they are created via docker-compose and PushProx client itself is running inside a container) I end up havin to expose via --fqdn the same hostname (i.e.: node-exporter) for many instances which, in turn, leads to clashes at proxy component level.

In this case it would be nice to be able to provide a --target=node-exporter flag at client level that along with a different --fqdn for each environment (e.g.: --fqdn=dev.foo.com, --fqdn=qa1.foo.com, --fqdn=qa2.foo.com) would allow to point to the same proxy.

I put together a PR for this: #80.

@mcastellini
Copy link
Author

@SuperQ is this proposal in line with PushProx's scope?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant