New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PushProx is using fqdn.get() which is deprecated #158

Open

insanity54 opened this issue Oct 14, 2023 · 0 comments

insanity54 commented Oct 14, 2023 •

edited

Loading

fqdn.Get() is deprecated

https://github.com/Showmax/go-fqdn/blob/869ae776d5881666b8e89ff9f536176ef1736658/legacy.go#L16

yet PushProx uses this function

https://github.com/prometheus-community/PushProx/blob/e69c705ede1ca350467309a9ca076ecf703bfd43/cmd/client/main.go#L45C70-L45C74

The replacement method to use is fqdn.FqdnHostname()

insanity54 changed the title ~~PushProx is using deprecated go-fqdn function~~ PushProx is using fqdn.get() which is deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment