Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent handling of property name / value casing between this package and your property package #1

Open
janigbg opened this issue Jan 14, 2022 · 0 comments

Comments

@janigbg
Copy link

janigbg commented Jan 14, 2022

I am working with an application that uses both this package and your property package.

We have noticed that the use of casing in comparisons is different between these packages.

property package handles casing in the following way (as I see it):

  • Match property names case sensitive when handling property filters / sets
  • Match string property values case insensitive when evaluating property filters

This package handles casing in the following way:

  • Match property names case insensitive when handling property filters / sets
  • Match string property values case sensitive when evaluating property filters

As I see it the handling of casing is a bug in this package, but please correct me if I am wrong.

I can provide a PR for this package if you agree that it should match the behaviour of the property package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant