Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore isNull localId when immediately following a Not operator so that 'null' in 'not null' is not considered a unique clause. #270

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jkotanchik-SB
Copy link
Contributor

Pull requests into cqm-execution require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@jkotanchik-SB jkotanchik-SB self-assigned this Sep 19, 2024
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7668-not-is-null branch 2 times, most recently from e00ad6a to 4b8b22f Compare September 19, 2024 14:24
adongare
adongare previously approved these changes Sep 19, 2024
…at 'null' in 'not null' is not considered a unique clause.
@jkotanchik-SB jkotanchik-SB merged commit fc2fcfe into master Sep 19, 2024
1 of 3 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-7668-not-is-null branch September 19, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants