Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7668: Ignore localIds not related to coverage calculation. #269

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Sep 13, 2024

Newer Translator versions (~3.14.0 and newer) generate far more localIds across more nodes. Previously, we used the presence of a localId as a key input to whether a node's localId should be collected for coverage/highlighting consideration. This had automatically excluded unrelated nodes. Most notably, Patient obj and Terminology references such as a Data Element's filter.

This update skips ELM nodes representing the Patient obj and nodes containing terminology references.

There may be other nodes that now get a localId that didn't previously that we will have to manually exclude.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@jkotanchik-SB jkotanchik-SB self-assigned this Sep 13, 2024
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7668-ignore-localIds-irrelevant-to-coverage-calc branch from 599c920 to 2a301b8 Compare September 13, 2024 18:45
Most notably, Patient obj and Terminology references such as a Data Element's filter.
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7668-ignore-localIds-irrelevant-to-coverage-calc branch from 2a301b8 to 7a08548 Compare September 13, 2024 18:48
@jkotanchik-SB jkotanchik-SB marked this pull request as ready for review September 13, 2024 19:45
@jkotanchik-SB jkotanchik-SB merged commit 4fba0d7 into master Sep 13, 2024
2 of 4 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-7668-ignore-localIds-irrelevant-to-coverage-calc branch September 13, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants