-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pull in cqm-models v4.1.2 #254
Conversation
Hi @dczulada, can you please review this? this pulls in cqm-models v4.1.2 to provide CQM |
…rned if value is 0. for more info https://oncprojectracking.healthit.gov/support/browse/BONNIEMAT-1096
@@ -462,7 +463,7 @@ module.exports = class ResultsHelpers { | |||
prettyResult += `${currentIndentation}}`; | |||
return prettyResult; | |||
} | |||
if (result) { | |||
if (result || result === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to fix the issue where results of aggregate functions being ignored if it is 0 (https://oncprojectracking.healthit.gov/support/browse/BONNIEMAT-1096)
I'm ignoring the vulnerability with word-wrap as there is no fix/patch available and it is dev dependency. |
This PR has following changes:
Pull requests into cqm-execution require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.
Submitter:
Reviewer 1:
Name:
Reviewer 2:
Name: