Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull in cqm-models v4.1.2 #254

Merged
merged 3 commits into from
Jun 30, 2023
Merged

pull in cqm-models v4.1.2 #254

merged 3 commits into from
Jun 30, 2023

Conversation

adongare
Copy link
Contributor

@adongare adongare commented Jun 26, 2023

This PR has following changes:

Pull requests into cqm-execution require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@adongare
Copy link
Contributor Author

adongare commented Jun 27, 2023

Hi @dczulada, can you please review this? this pulls in cqm-models v4.1.2 to provide CQM is operator suport for entities. Also, addresses few vulnerabilities.

jkotanchik-SB
jkotanchik-SB previously approved these changes Jun 27, 2023
@@ -462,7 +463,7 @@ module.exports = class ResultsHelpers {
prettyResult += `${currentIndentation}}`;
return prettyResult;
}
if (result) {
if (result || result === 0) {
Copy link
Contributor Author

@adongare adongare Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to fix the issue where results of aggregate functions being ignored if it is 0 (https://oncprojectracking.healthit.gov/support/browse/BONNIEMAT-1096)

@adongare
Copy link
Contributor Author

I'm ignoring the vulnerability with word-wrap as there is no fix/patch available and it is dev dependency.

@adongare adongare merged commit 4e3ecf4 into master Jun 30, 2023
2 of 4 checks passed
@adongare adongare deleted the pull_cqm_models_4.1.2 branch November 21, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants