Skip to content

Commit

Permalink
Remove TODO and add note comment
Browse files Browse the repository at this point in the history
  • Loading branch information
lmd59 committed Aug 6, 2024
1 parent dd61375 commit 28e5af2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/util/exportToNDJson.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,13 @@ describe('check export logic', () => {
expect(fs.existsSync(expectedFileNameServiceRequest)).toBe(true);
});
test('Expect folder created and export to fail when _typeFilter parameter is retrieved from request and contains an invalid param', async () => {
// Note: invalid types are checked in the export service
await exportToNDJson({ clientEntry: clientId, type: mockType, typeFilter: typeFilterWithInvalidType });
expect(fs.existsSync('./tmp/123456')).toBe(true);
expect(fs.existsSync(expectedFileNameInvalidType)).toBe(false);
});
test('Expect export to fail when _typeFilter parameter is retrieved from request but the value set is invalid', async () => {
await exportToNDJson({ clientEntry: clientId, type: mockType, typeFilter: typeFilterWOValueSet });
// TODO: this currently fails and does not create a folder (throws error instead). Do we want a more graceful response?
expect(fs.existsSync(expectedFileNameWOValueSet)).toBe(false);
});
test('Expect folder created and export successful when _bySubject parameter is retrieved from request', async () => {
Expand Down

0 comments on commit 28e5af2

Please sign in to comment.