Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove generated node check in ValidatePositionProcessor #3805

Open
Rawi01 opened this issue Jan 3, 2025 · 0 comments · May be fixed by #3839
Open

[BUG] Remove generated node check in ValidatePositionProcessor #3805

Rawi01 opened this issue Jan 3, 2025 · 0 comments · May be fixed by #3839
Assignees
@Rawi01

Comments

@Rawi01
Copy link
Collaborator

Rawi01 commented Jan 3, 2025

The ValidatePositionProcessor currently skips generated nodes during updated position validation. While this seems unnecessary, removing it locally led to additional failures.

At least one failure, observed in LoggerSlf4j, seems to be a real bug.

Additional context: #3800
@Rawi01 Rawi01 mentioned this issue Jan 4, 2025
Merged
@Rawi01 Rawi01 self-assigned this Feb 23, 2025
Rawi01 added a commit to Rawi01/lombok that referenced this issue Feb 25, 2025
@Rawi01
[fixes projectlombok#3805] Create copies for expressions
Loading
Loading status checks…
4404ef9
@Rawi01 Rawi01 linked a pull request Mar 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rawi01 Rawi01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create copies for expressions Rawi01/lombok
1 participant
@Rawi01