Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] JDK 24 Compatibility #3772

Open
mmoayyed opened this issue Oct 31, 2024 · 3 comments
Open

[FEATURE] JDK 24 Compatibility #3772

mmoayyed opened this issue Oct 31, 2024 · 3 comments

Comments

@mmoayyed
Copy link
Contributor

Describe the feature

Allow lombok to support building against JDK 24.

Describe the target audience

While JDK 24 is still in EA mode as of this writing, there are EA builds available nonetheless that one can use for experimentation and preparation against the next JDK release.

Additional context

Lombok likely requires a new version of the lombok patcher to support the new Opcodes.V24 constant for Java 24.

Please see projectlombok/lombok.patcher#17

@lprimak
Copy link

lprimak commented Feb 2, 2025

JDK 24 is now in RampDown phase. This means that it's safe to get this finalized.

It would be really great if Lombok is, for the first time, compatible with the new JDK before its release date.

ASM is already compatible.

@Rawi01
Copy link
Collaborator

Rawi01 commented Feb 5, 2025

Rampdown doesn't mean that there are no breaking changes in the compiler. As far as I know we only have to adjust one small thing besides the mandatory ASM update.

@lprimak
Copy link

lprimak commented Feb 5, 2025

Rampdown doesn't mean that there are no breaking changes in the compiler.

See https://devclass.com/2025/01/20/java-24-feature-frozen-as-it-enters-rampdown-phase-two/
While technically it could be broken, but only for "extraordinary" issues.
I would say my statement above is correct, that it's safe for Lombok to finalize JDK 24 features.

And thank you for your work on Lombok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants