Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter items form confusion #3229

Open
taylor-steve opened this issue Oct 21, 2024 · 1 comment
Open

Filter items form confusion #3229

taylor-steve opened this issue Oct 21, 2024 · 1 comment

Comments

@taylor-steve
Copy link
Contributor

During testing it was noticed that the "Filter items" (Configuration > General > Filter items) form seems to have no way to remove an applied filter. After a user submits the form with both field and value, if they blank out both fields and resubmit there is a flash message stating
Field can't be blank<br/>Value can't be blank

It might be nice to be able to remove a filter. We had to create a new exhibit to continue testing.

If there's a reason removing a filter isn't technically possible, we may want to communicate that to the user.

@cbeer
Copy link
Member

cbeer commented Oct 22, 2024

Is there a real-world use case for a single exhibit to show every indexed item? I know there's one the single-exhibit case (using the application-wideSpotlight::Engine.config.filter_resources_by_exhibit = false), but I'm not sure what not filtering at all would accomplish (and there's a reason this page is there just for superadmins 🤷‍♂️ )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants