-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add background highlighting to Collection overview section when active #1280
Comments
I feel like this might be a little more complicated than the ticket suggests, and we might need additional clarification to figure out how to do it right. Gary noted above:
...which doesn't seem to happen in #1339 if you load, for example, This gets a little weird when you throw scrolling into it. If I scroll down the page to look at "background", the "summary" link will still be highlighted in the sidebar, even though I'm not "looking" at the summary section anymore. You don't notice this right now because the sidebar scrolls away along with the main content, but #1312 will make it sticky, so it'll be more obvious. To me, the behavior that fits Gary's notes above is actually something more like bootstrap's scrollspy: highlight something based on where the user is currently "looking", i.e. what part of the page's content is currently in the viewport. That satisfies the conditions:
|
Discussion: Justin's PR #1339 is a subset but perhaps not covering all the bullet points in this ticket. |
@thatbudakguy Yes, what I was suggesting is the scrollspy behavior. As you note, #1312 is also needed to make this behavior work in the most ideal way (ensures the user can always see the highlighted overview section that they've selected). I guess I assumed at the time that #1312 was pretty straightforward and that would be in place for this ticket to work with. I'm not sure if I'm missing any other hurdles or concerns about doing this, but am happy to meet to discuss in more detail. |
Currently when the user selects a node from the Collection contents tree, the component page for that node is displayed in the main content area and background highlighting is added to that node in the Collection contents tree. This highlighting helps the user understand what component is currently selected, and reinforces the association between the sidebar navigation element and its associated content in the main content area:
We should do the same thing for the Collection overview section, for the same reasons:
Some implications of this:
The text was updated successfully, but these errors were encountered: