Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill subprocess_mixin children with parent #183

Open
wcpettus opened this issue Apr 12, 2019 · 0 comments
Open

kill subprocess_mixin children with parent #183

wcpettus opened this issue Apr 12, 2019 · 0 comments

Comments

@wcpettus
Copy link

Any INT/TERM command to the top-level dragonfly process isn't propagated down to the children in subprocess_mixin. Because the default structure is a "control" subprocess and a "worker" subprocess that is actually handling the business, this results in two orphaned children that have to be cleaned up manually.

Our default process stop is a graceful INT, so on_channel_closed (https://github.com/project8/dripline-python/blob/master/dripline/core/service.py#L190) is called, which could attempt to cleanup any endpoints (if the subprocesses are added as endpoints)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant