Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

level warning from AMQP handler #172

Open
wcpettus opened this issue Jan 28, 2019 · 1 comment
Open

level warning from AMQP handler #172

wcpettus opened this issue Jan 28, 2019 · 1 comment

Comments

@wcpettus
Copy link

We have a hard-coded warning print statement in the amqp handler:
https://github.com/project8/dragonfly/blob/develop/dragonfly/status_log_handlers/amqp_handler.py#L48

Which results in seeing this message for every dragonfly command. We should probably remind ourselves what the desired behavior is, remove this warning, and make an issue to get the desired behavior. Or if it's easy just do it all at once.

@wcpettus
Copy link
Author

a little more detail on when/why this occurs:

To achieve a warning-less version matching our current implementation:

  • replace line 25 of AMQPHandler with super(AMQPHandler, self).setLevel(logging.WARNING)
  • replace the entire setLevel method with a dummy method to do nothing, so that bin/dragonfly doesn't overwrite the setting

Future improvement - we have an outstanding issue to disable these slack broadcasts when running interactively (see #110), which can be done by changing the log level of the AMQP handler or disabling it. We should not do conflicting things in resolving these two issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant