Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handler update_parser method useless #121

Open
wcpettus opened this issue Oct 3, 2017 · 2 comments
Open

handler update_parser method useless #121

wcpettus opened this issue Oct 3, 2017 · 2 comments

Comments

@wcpettus
Copy link

wcpettus commented Oct 3, 2017

Because self.add_dragonfly_handlers(extra_args) (containing the handler.update_parser()) is called after these_args = argparse.ArgumentParser.parse_args(self), parser instructions contained by the handlers are not included in dragonfly.

@laroque
Copy link
Member

laroque commented Oct 3, 2017

oh good... I thought that they used to work, can we just move the order or does that not work?

@wcpettus
Copy link
Author

wcpettus commented Oct 3, 2017

It's complicated -
If you moved the call to self.add_dragonfly_handlers(extra_args) from the middle of parse_args to the bottom of init where self.add_dragonfly_subcommands() is called, that would make sense. But extra_args is modified by the argparser (because the amqp handler defines a Service, which needs a broker).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants