Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stage 0 crashes if guest kernel command line is > 256 chars #4981

Open
kevinloughlin opened this issue Apr 3, 2024 · 0 comments
Open

Stage 0 crashes if guest kernel command line is > 256 chars #4981

kevinloughlin opened this issue Apr 3, 2024 · 0 comments

Comments

@kevinloughlin
Copy link
Contributor

kevinloughlin commented Apr 3, 2024 •
edited
Loading

#4928 includes the raw kernel command line in Stage0 DICE measurements. However, command lines > 256 chars exceed the space allocated in the root layer certificate, resulting in a crash during Stage0 boot. Simply increasing the certificate size (#4946) resulted in a different breakage and was hence reverted, meaning command lines > 256 chars are not currently supported.
kevinloughlin added a commit to kevinloughlin/oak that referenced this issue Apr 4, 2024
@kevinloughlin
Temporarily limit kernel command line length in Stage0 measurements
b6a628e 
As a temporary workaround for project-oak#4981, limit the kernel command line
included in the Stage0 DICE measurements to 256 chars (1024 bytes).
@kevinloughlin kevinloughlin mentioned this issue Apr 4, 2024
Merged
kevinloughlin added a commit to kevinloughlin/oak that referenced this issue Apr 4, 2024
@kevinloughlin
Fail command line validation for long cmdlines unless skipped
13bdb6f 
Since the temporary workaround for project-oak#4981 truncates length command lines
to 256 characters, fail verification for any command lines >= 256
(characters since it may have been truncated), unless the reference
value is set to Skip.
@kevinloughlin kevinloughlin changed the title Stage 0 crashes if guest kernel command line is > 1024 bytes (256 chars) Stage 0 crashes if guest kernel command line is > 256 chars Apr 5, 2024
kevinloughlin added a commit that referenced this issue Apr 5, 2024
@kevinloughlin
Temporarily limit kernel command line length in Stage0 measurements (#…
0869b75 
…4983)

* Temporarily limit kernel command line length in Stage0 measurements

As a temporary workaround for #4981, limit the kernel command line
included in the Stage0 DICE measurements to 256 chars (1024 bytes).

* Fail command line validation for long cmdlines unless skipped

Since the temporary workaround for #4981 truncates length command lines
to 256 characters, fail verification for any command lines >= 256
(characters since it may have been truncated), unless the reference
value is set to Skip.

* FIXUP: update TODO format per reviewer feedback

* FIXUP: fix formatting in updated TODOs

* FIXUP: workaround linter issue (b/333067027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinloughlin