Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm ent tag logic is still needed #4745

Open
tiziano88 opened this issue Feb 1, 2024 · 2 comments
Open

Confirm ent tag logic is still needed #4745

tiziano88 opened this issue Feb 1, 2024 · 2 comments
Assignees

Comments

@tiziano88
Copy link
Collaborator

@thmsbinder I don't remember if this logic is currently used, or was it replaced by the kokoro workflow? If unused, I'd like to remove it and simplify things a bit (bot here and in ent itself).

- name: Upload signed tag to Ent
run: |
set -o errexit
set -o nounset
set -o xtrace
set -o pipefail
file="${{ needs.get_inputs.outputs.artifact-path }}"
binary_name="$(basename "${file}")"
ent tag set --public-key=${{ inputs.ent-public-key }} \
--label="artifact_${GITHUB_SHA}_${binary_name}" \
--target=${{ steps.ent_upload_binary.outputs.binary_digest }}
ent tag set --public-key=${{ inputs.ent-public-key }} \
--label="provenance_${GITHUB_SHA}_${binary_name}" \
--target=${{ steps.ent_upload_provenance.outputs.provenance_digest }}

@tiziano88 tiziano88 self-assigned this Feb 1, 2024
@tiziano88
Copy link
Collaborator Author

In fact, same question about the "normal" ent upload -- perhaps that's not needed any more either?

@thmsbinder
Copy link
Collaborator

We use the tag feature to access the provenance for a binary. Lines 184-186 are needed. The binaries are downloaded from Kokoro and not from Ent. That's a bit asymmetric but OK. See also the internal ent_client.py. Transparent Release only reads from Ent, it doesn't write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants