Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto files are not resolved correctly when compiled from repos from other workspaces #4573

Open
tiziano88 opened this issue Dec 19, 2023 · 2 comments
Assignees

Comments

@tiziano88
Copy link
Collaborator

We currently use this as a hack to find our way to the protos (and other non-rust files) from the root of our repo:

oak/.cargo/config.toml

Lines 30 to 33 in dbbe410

# A cargo environment variable holding the root directory of our repo.
# We can use WORKSPACE_ROOT instead of `std::env::current_dir()` to navigate in the repo.
[env]
WORKSPACE_ROOT = { value = "", relative = true }

unfortunately this does not work when another workspace / repo depends on one of our crates ,since that env variable will be set relative to that repo, and therefore the proto messages won't be found there

cc @dzmitry-huba @dingelish

@tiziano88
Copy link
Collaborator Author

cc @agl

@tiziano88 tiziano88 self-assigned this Jan 2, 2024
@tiziano88
Copy link
Collaborator Author

tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 2, 2024
Add a manual test to check regressions in the future.

Ref project-oak#4573
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 2, 2024
Add a manual test to check regressions in the future.

Ref project-oak#4573
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 2, 2024
Add a manual test to check regressions in the future.

Ref project-oak#4573
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 2, 2024
Add a manual test to check regressions in the future.

Ref project-oak#4573
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 2, 2024
Add a manual test to check regressions in the future.

Ref project-oak#4573
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 2, 2024
Add a manual test to check regressions in the future.

Ref project-oak#4573
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 2, 2024
Add a manual test to check regressions in the future.

Ref project-oak#4573
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 2, 2024
Add a manual test to check regressions in the future.

Ref project-oak#4573
tiziano88 added a commit that referenced this issue Jan 3, 2024
Add a manual test to check regressions in the future.

Ref #4573
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 3, 2024
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 3, 2024
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant