Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to support listing all jobs and selecting a particular job's dashboard #178

Open
atinsood opened this issue Jun 27, 2022 · 4 comments
Assignees
Labels

Comments

@atinsood
Copy link

Objective

Currently the dashboard can be launched pointing to a single job and does not provide the ability to list all the existing jobs that were run.

what would be helpful is rather than pointing to one job, if we can list all the jobs along with their status.

Proposed implementation

In addition to pointing to a specific location of a job /Users/apollo/work/research/cil/opensource/codeflare-cli/tests/plugin-codeflare/dashboard/inputs/1 , if we point a level higher where list of all the jobs are present /Users/apollo/work/research/cil/opensource/codeflare-cli/tests/plugin-codeflare/dashboard/inputs, we can easily cycle through all the jobs and figure out status, start time, end time etc of the jobs. this directory can be a user speficied directory or we can assume that these details are present in some ~/.codeflare repo.

we can then populate this data in a picker, or have the initial dashboard as just a table that has all the jobs listed.

the user can then proceed from there to select a specific job. the workflow after that will be the same as the current workflow.

@atinsood atinsood changed the title ability to support listing all jobs and selecting a particular job ability to support listing all jobs and selecting a particular job's dashboard Jun 27, 2022
@starpit
Copy link
Collaborator

starpit commented Jun 29, 2022

Q0: How do we obtain the list of prior jobs?
A0: $LOGDIR_URI either in process.env or in the job.json env

Q1: What UI do we use for showing the user the list of prior jobs
A1a: status stripe with popover that shows filterable select (like kubernetes context selector); disadvantage: how do i know which to select, based on just the job id (which is some cryptic uuid);
A1b: how: standard kui table; where???; advantage: put meaning into the columns (time, duration, application name/class, cluster, ...)
A1c: status stripe with popover that shows table! or status stripe onclick show modal with table; status stripe onclick show new tab with table

Q2: When a user selects/clicks on a prior job, where do we show the dashboard
A2a: new tab? this would require changing the tab title from "Dashboard" to "Dashboard "
A2b: smash it into the existing Dashboard tab
A2c: new window

@atinsood
Copy link
Author

atinsood commented Jun 29, 2022

Q1: What UI do we use for showing the user the list of prior jobs
A1a: status stripe with popover that shows filterable select (like kubernetes context selector); disadvantage: how do i know which to select, based on just the job id (which is some cryptic uuid);
A1b: how: standard kui table; where???; advantage: put meaning into the columns (time, duration, application name/class, cluster, ...)
A1c: status stripe with popover that shows table! or status stripe onclick show modal with table; status stripe onclick show new tab with table

I am inclined towards standard kui table possibly in a new tab like what you suggest in the next question. I think columns like status and start time are worth showing.

basically the dashboard becomes 2 tabs, 1 that can list the jobs and another tab that show the details of the job that we clicked on

@starpit starpit reopened this Jun 29, 2022
@atinsood
Copy link
Author

Q0: How do we obtain the list of prior jobs?
A0: $LOGDIR_URI either in process.env or in the job.json env

@starpit do you think we can pass this as a part of the command as well

codeflare dashboard --home=<> or export CF_DASHBOARD_HOME=<> codeflare dashboard

@starpit starpit reopened this Jun 29, 2022
@PabloCarmona
Copy link
Contributor

  • create/connect with a s3 bucket in aws or ibm cloud bucket
  • use of kui native table rendering with the use of -la arguments
  • override onclick behavior of list items to run codeflare dashboards
  • run dashboards in another or same tab
  • give ability to dashboard command to open in a new tab with the use of replay and commentary commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants