Skip to content

Commit f356434

Browse files
committed
fix: avoid bumping profile lastUsedTime for tray menu watchers
1 parent 185c7b0 commit f356434

File tree

4 files changed

+13
-11
lines changed

4 files changed

+13
-11
lines changed

package-lock.json

+9-9
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

plugins/plugin-codeflare/src/tray/watchers/profile/active-runs.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ export default class ProfileActiveRunWatcher {
4949
try {
5050
const resp = await cli(["madwizard", "guide", guidebook], undefined, {
5151
profile,
52-
clean: false /* don't kill the port-forward subprocess! we'll manage that */,
52+
bump: false, // don't bump the lastUsedTime of the profile
53+
clean: false, // don't kill the port-forward subprocess! we'll manage that
5354
interactive: false,
5455
store: process.env.GUIDEBOOK_STORE,
5556
})

plugins/plugin-codeflare/src/tray/watchers/profile/status.ts

+1
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ export default class ProfileStatusWatcher {
7272
"guide",
7373
"-q",
7474
"-y",
75+
"--no-bump", // don't bump the lastUsedTime of the profile
7576
"--profile",
7677
profile,
7778
"ml/ray/cluster/kubernetes/is-ready",

plugins/plugin-madwizard/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"access": "public"
2424
},
2525
"dependencies": {
26-
"madwizard": "^0.22.2",
26+
"madwizard": "^0.23.0",
2727
"@guidebooks/store": "^0.12.6"
2828
}
2929
}

0 commit comments

Comments
 (0)