Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIFO uniqueness logic prevents wrapper scripts for test applications #37485

Open
2 tasks
andy31415 opened this issue Feb 8, 2025 · 0 comments
Open
2 tasks

Comments

@andy31415
Copy link
Contributor

andy31415 commented Feb 8, 2025

Our current logic is to suffix PID to fifo names. Like /tmp/chip_rvc_fifo_....

However this means that if we create a wrapper launcher script for apps (like for example to use RR or setup environment variables like for coverage output) the scripts take the "shell launcher PID" while the app uses its own "PID".

This results in applications failing to actually communicate. We need to:

  • tests should detect if FIFO file exists before writing (otherwise this was super hard to debug)
  • applications should somehow take in the FIFO suffix to use. Either command line arguments (then script CI arguments can control this) or environment variables or something else passed through.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant