Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Suggestions for Modifying the Android Project Environment and Guide #36743

Closed
pachuho opened this issue Dec 6, 2024 · 1 comment
Closed

Comments

@pachuho
Copy link
Contributor

pachuho commented Dec 6, 2024

Build issue(s)

Here is my suggestion regarding updating the JDK, Gradle, and AGP (Android Gradle Plugin) versions in the ChipTool Android project.

Reasons for the update:

Decreasing number of Intel-based MacBook users

With the increasing adoption of MacBooks equipped with Apple Silicon chips, more users are likely to require JDK 17 or higher, as indicated in the guide documentation. The project currently uses JDK 1.8, which may lead to build failures for Apple Silicon MacBook users.

android_building

image

Keeping the development environment up to date

The ChipTool Android project is currently using Gradle 7.1.1, JDK 1.8, and Kotlin 1.8.10.
This is not merely a criticism of legacy setups.
During the build process, I encountered Kotlin-related errors and had to install Kotlin to resolve them.
스크린샷 2024-12-05 오후 3 03 51

Other users are likely to encounter similar issues since the commonly installed Kotlin version, typically installed via Homebrew, is 2.1.0 or higher, which might not be compatible with the current Gradle, AGP, and JDK versions in the project, causing build failures.
Reference issue: #36030

I believe such requirements will only increase over time.
Therefore, I recommend updating the project versions accordingly.
(Additionally, I think it would be beneficial to migrate the Android project configuration to Kotlin DSL (kts), among other improvements.)

Thank you for reading, and I look forward to your feedback.

Platform

android

Anything else?

If you agree with this suggestion, I would like to take on the task of updating the versions myself!
(This is also just a suggestion.)

@yunhanw-google
Copy link
Contributor

Thanks for the suggestion, we have upgraded the android build with java 17 and gradle 7.3.3, and kotlin 2.0.
#33837

@github-project-automation github-project-automation bot moved this from Todo to Done in [Platform] Android Feb 3, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in [Build] Build Issues Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

No branches or pull requests

3 participants