Skip to content

Commit fa0b299

Browse files
andy31415andreilitvinDamian-Nordic
authored
Make pullapprove NOT always add 57 reviewers to every PR. (#35845)
* Make pullapprove NOT always add 57 reviewers to every PR. Added CODEOWNERS for platforms, so that platform changes are visible to relevant persons. * Fix up codeowners * Move codeowners to an obvious top visible name * Use full paths for owners * Fix names * Fix group names: shared is a concept in pullapprove * Try to see if owner name without at is ok * Undo at syntax * Align paths a bit better * Add some file types to codeowners * Docker image paths * Update CODEOWNERS Co-authored-by: Damian Królik <[email protected]> --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Damian Królik <[email protected]>
1 parent ba7c3e0 commit fa0b299

File tree

3 files changed

+90
-21
lines changed

3 files changed

+90
-21
lines changed

.github/CODEOWNERS

-2
This file was deleted.

.pullapprove.yml

+19-19
Original file line numberDiff line numberDiff line change
@@ -84,79 +84,79 @@ groups:
8484
reviewers:
8585
teams: [reviewers-amazon]
8686
reviews:
87-
request: 10
87+
request: 0 # Do not auto-add
8888
shared-reviewers-apple:
8989
type: optional
9090
conditions:
9191
- files.include('*')
9292
reviewers:
9393
teams: [reviewers-apple]
9494
reviews:
95-
request: 10
95+
request: 0 # Do not auto-add
9696
shared-reviewers-bosch:
9797
type: optional
9898
conditions:
9999
- files.include('*')
100100
reviewers:
101101
teams: [reviewers-bosch]
102102
reviews:
103-
request: 10
103+
request: 0 # Do not auto-add
104104
shared-reviewers-comcast:
105105
type: optional
106106
conditions:
107107
- files.include('*')
108108
reviewers:
109109
teams: [reviewers-comcast]
110110
reviews:
111-
request: 10
111+
request: 0 # Do not auto-add
112112
shared-reviewers-dyson:
113113
type: optional
114114
conditions:
115115
- files.include('*')
116116
reviewers:
117117
teams: [reviewers-dyson]
118118
reviews:
119-
request: 10
119+
request: 0 # Do not auto-add
120120
shared-reviewers-espressif:
121121
type: optional
122122
conditions:
123123
- files.include('*')
124124
reviewers:
125125
teams: [reviewers-espressif]
126126
reviews:
127-
request: 10
127+
request: 0 # Do not auto-add
128128
shared-reviewers-google:
129129
type: optional
130130
conditions:
131131
- files.include('*')
132132
reviewers:
133133
teams: [reviewers-google]
134134
reviews:
135-
request: 10
135+
request: 0 # Do not auto-add
136136
shared-reviewers-grundfos:
137137
type: optional
138138
conditions:
139139
- files.include('*')
140140
reviewers:
141141
teams: [reviewers-grundfos]
142142
reviews:
143-
request: 10
143+
request: 0 # Do not auto-add
144144
shared-reviewers-irobot:
145145
type: optional
146146
conditions:
147147
- files.include('*')
148148
reviewers:
149149
teams: [reviewers-irobot]
150150
reviews:
151-
request: 10
151+
request: 0 # Do not auto-add
152152
shared-reviewers-lg:
153153
type: optional
154154
conditions:
155155
- files.include('*')
156156
reviewers:
157157
teams: [reviewers-lg]
158158
reviews:
159-
request: 10
159+
request: 0 # Do not auto-add
160160
shared-reviewers-logitech:
161161
type: optional
162162
conditions:
@@ -172,31 +172,31 @@ groups:
172172
reviewers:
173173
teams: [reviewers-nordic]
174174
reviews:
175-
request: 10
175+
request: 0 # Do not auto-add
176176
shared-reviewers-nxp:
177177
type: optional
178178
conditions:
179179
- files.include('*')
180180
reviewers:
181181
teams: [reviewers-nxp]
182182
reviews:
183-
request: 10
183+
request: 0 # Do not auto-add
184184
shared-reviewers-samsung:
185185
type: optional
186186
conditions:
187187
- files.include('*')
188188
reviewers:
189189
teams: [reviewers-samsung]
190190
reviews:
191-
request: 10
191+
request: 0 # Do not auto-add
192192
shared-reviewers-eve:
193193
type: optional
194194
conditions:
195195
- files.include('*')
196196
reviewers:
197197
teams: [reviewers-eve]
198198
reviews:
199-
request: 10
199+
request: 0 # Do not auto-add
200200
# shared-reviewers-signify disabled for now, because the reviewers-signify
201201
# team is empty and pullapprove seems to mis-handle that badly and treats
202202
# _all_ reviewers as being in this group.
@@ -210,39 +210,39 @@ groups:
210210
# reviewers:
211211
# teams: [reviewers-signify]
212212
# reviews:
213-
# request: 10
213+
# request: 0 # Do not auto-add
214214
shared-reviewers-silabs:
215215
type: optional
216216
conditions:
217217
- files.include('*')
218218
reviewers:
219219
teams: [reviewers-silabs]
220220
reviews:
221-
request: 10
221+
request: 0 # Do not auto-add
222222
shared-reviewers-somfy:
223223
type: optional
224224
conditions:
225225
- files.include('*')
226226
reviewers:
227227
teams: [reviewers-somfy]
228228
reviews:
229-
request: 10
229+
request: 0 # Do not auto-add
230230
shared-reviewers-tcl:
231231
type: optional
232232
conditions:
233233
- files.include('*')
234234
reviewers:
235235
teams: [reviewers-tcl]
236236
reviews:
237-
request: 10
237+
request: 0 # Do not auto-add
238238
shared-reviewers-qorvo:
239239
type: optional
240240
conditions:
241241
- files.include('*')
242242
reviewers:
243243
teams: [reviewers-qorvo]
244244
reviews:
245-
request: 10
245+
request: 0 # Do not auto-add
246246

247247
############################################################
248248
# Base Required Reviewers

CODEOWNERS

+71
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
1+
/src/platform/ASR/ @tx2rx
2+
asr/ @tx2rx
3+
chip-build-asr/ @tx2rx
4+
5+
/src/platform/Ameba/ @pankore
6+
ameba/ @pankore
7+
chip-build-ameba/ @pankore
8+
9+
/src/platform/Beken/ @zhengyaohan
10+
11+
*.mm @project-chip/reviewers-apple
12+
darwin/ @project-chip/reviewers-apple
13+
/src/darwin/ @project-chip/reviewers-apple
14+
/src/platform/Darwin/ @project-chip/reviewers-apple
15+
/examples/darwin-framework-tool/ @project-chip/reviewers-apple
16+
17+
/src/platform/ESP32/ @project-chip/reviewers-espressif
18+
esp32/ @project-chip/reviewers-espressif
19+
chip-build-esp32/ @project-chip/reviewers-espressif
20+
chip-build-esp32-qemu/ @project-chip/reviewers-espressif
21+
22+
/src/platform/Infineon/ @ifyall
23+
infineon/ @ifyall
24+
chip-build-infineon/ @ifyall
25+
26+
/src/platform/NuttX/ @zhhyu7
27+
chip-build-nuttx/ @zhhyu7
28+
29+
/src/platform/Tizen/ @arkq
30+
tizen/ @arkq
31+
chip-build-tizen/ @arkq
32+
chip-build-tizen-qemu/ @arkq
33+
34+
*.java @project-chip/reviewers-google
35+
*.kt @project-chip/reviewers-google
36+
android/ @project-chip/reviewers-google
37+
/src/examples/chef/ @project-chip/reviewers-google
38+
/integrations/appengine/ @project-chip/reviewers-google
39+
/integrations/cloudbuild/ @project-chip/reviewers-google
40+
/integrations/compute_engine/ @project-chip/reviewers-google
41+
chip-build-java/ @project-chip/reviewers-google
42+
chip-build-android/ @project-chip/reviewers-google
43+
44+
/src/platform/bouffalolab/ @wy-hh
45+
chip-build-bouffalolab/ @wy-hh
46+
47+
cc13xx_26xx/ @s-jain2022
48+
cc32xx/ @s-jain2022
49+
50+
/src/platform/mt793x/ @pakls
51+
nrfconnect/ @project-chip/reviewers-nordic
52+
chip-build-nrf-platform/ @project-chip/reviewers-nordic
53+
Zephyr/ @project-chip/reviewers-nordic @project-chip/reviewers-nxp @s07641069
54+
55+
56+
nxp/ @project-chip/reviewers-nxp
57+
chip-build-nxp/ @project-chip/reviewers-nxp
58+
chip-build-nxp-zephyr/ @project-chip/reviewers-nxp
59+
chip-build-k32w/ @project-chip/reviewers-nxp
60+
61+
qpg/ @dvdm-qorvo
62+
63+
silabs/ @project-chip/reviewers-silabs
64+
chip-build-efr32/ @project-chip/reviewers-silabs
65+
66+
stm32/ @STYoannZamaron
67+
68+
telink/ @s07641069
69+
chip-build-telink/ @s07641069
70+
71+
webos/ @joonhaengHeo

0 commit comments

Comments
 (0)