Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redactions #23

Open
Thaodan opened this issue Jun 26, 2022 · 4 comments
Open

Redactions #23

Thaodan opened this issue Jun 26, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@Thaodan
Copy link
Contributor

Thaodan commented Jun 26, 2022

I would suggest that redactions could be handled as in other similar clients such as purple-slack.
E.g.
Chat:

<user> <data> bar bar

Reduction:

Reducted:  
<user> <data> bar bar
Reason:
bar
@progval
Copy link
Owner

progval commented Jun 26, 2022

Do you mean redactions?

The reason it's not implemented yet, is that it requires keeping track of messages received from the room, which can be tricky to get right (eg. they need to be expired in order to avoid leaking memory)

@progval progval added the enhancement New feature or request label Jun 26, 2022
@Thaodan Thaodan changed the title Reductions Redactions Jun 26, 2022
@Thaodan
Copy link
Contributor Author

Thaodan commented Jun 26, 2022

Do you mean redactions?

Yes, fixed the title.

Can we query the message again when it is redacted? I see other similar clients implementing it. It would be useful for keeping context of a message.

@progval
Copy link
Owner

progval commented Jun 26, 2022

Unfortunately no, homeservers are expected to remove messages from their database upon redaction.

@progval
Copy link
Owner

progval commented Jul 3, 2022

I wrote a basic implementation of this in 6fec00a. No message storage, it just says an event was deleted; which shows up as a reply to the deleted message if you use IRCCloud (or any other client that supports +draft/reply)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants