-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corpus Analysis with Voyant Tools (translation from Spanish) #608
Comments
Hello @giuliataurino, @asmartinez and @zizneroz, You can find the key files here:
You can review a preview of the lesson here: Thank you for your submission @asmartinez and @zizneroz.
Thank you! ✨ |
Hello Alberto @asmartinez and Eime Javier @zizneroz, What's happening now?Your lesson has been moved to the next phase of our workflow which is Phase 2: Initial Edit. In this phase, your editor Editor @giuliataurino will read your lesson, and provide some initial feedback. Giulia will post feedback and suggestions as a comment in this issue, so that you can revise your draft in the following phase (Phase 3: Revision 1). %%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
'cScale1': '#882b4f', 'cScaleLabel1': '#ffffff',
'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
} } }%%
timeline
Section Phase 1 <br> Submission
Who worked on this? : Publishing Assistant (@charlottejmc)
All Phase 1 tasks completed? : Yes
Section Phase 2 <br> Initial Edit
Who's working on this? : Editor (@giuliataurino)
Expected completion date? : July 14
Section Phase 3 <br> Revision 1
Who's responsible? : Authors (@asmartinez + zizneroz)
Expected timeframe? : ~30 days after feedback is received
|
Hello again Alberto @asmartinez and Eime Javier @zizneroz, I've sent you each an invitation to join us as Outside Collaborators here on GitHub. This will give you the 'write access' you'll need to add your figure captions and The original lesson was published before we introduced a requirement for alt-text to support all figures, so we will need to ask you to write the visual descriptions of each figure. However, you can translate / or adapt the captions from the Spanish original as follows:
With many thanks, |
Hi @charlottejmc, Thank you for uploading the translation and making the necessary edits. Should I then direct reviewers to ignore the different in the subheadings titles and structure and focus on the content of the paragraphs only? Best, Giulia |
Hi Alberto @asmartinez and Eime Javier @zizneroz, Thank you for taking upon this translation and the additional work required for adapting the examples and new formatting guidelines. Overall, the translation looks good. In the next few points, I will share a lot of notes and suggestions that are fairly common edits in first draft translations. Bear in mind that not all changes are needed some are questions or suggestions, some of them are reminder of what @anisa-hawes and @charlottejmc already pointed at in previous comments, and few might be notes for the editorial team itself (Anisa and Charlotte, I'll let you make the call on which edits should be taken upon by the editorial team). Despite the number of comments below, I want to reiterate that the quality of the translation is good and we much appreciated your work to make this original submission accessible to non-Spanish speakers. Introduction
Creating a Plain Text Corpus
Loading the Corpus
Exploring the corpus
Document summary: basic characteristics of your set of text
Cirrus and summary: frequencies and stop word filters
Terms
Words in context
Activity Answers
I remain available should you have any questions or doubts about these reviews. Best, Giulia |
Hi Giulia (@giuliataurino), Can you send me the Git collaboration invite again? The last one expired because I couldn't find it in my emails. Best, Eime |
Hello Eime @zizneroz. I already re-sent you the invitation to join us as an Outside Collaborator. We ask authors to work on their own files with direct commits: we don't want you to use the Pull Request system, or fork our repo to edit in ph-submissions. You can make direct commits to your file here: en/drafts/translations/corpus-analysis-voyant-tools.md. With thanks, Anisa. |
Hi Anisa @anisa-hawes, Got it. I accepted the invite and I'll make the commits directly to the file. Thank you! |
Hello @asmartinez, @zizneroz and @giuliataurino, I just wanted to point out that I have edited Giulia's comment slightly to turn each point into a checkbox. This should help us keep track of which changes have been made, and which ones still need to be looked at! You'll see that I have also added [Publishing Team] to several points – these are things @anisa-hawes and I will take care of ourselves. Thank you! |
Hello again @zizneroz, I saw from your commit that you have been working on the figure alt-text. Thank you! However, I think we will still need some more work to make them truly effective as 'alt-text'. This descriptive element enables screen readers to read the information conveyed in the images for people with visual impairments, different learning abilities, or who cannot otherwise view them, for example due to a slow internet connection. It's important to say that We have found Amy Cesal's guide to Writing Alt Text for Data Visualization useful. This guide advises that alt-text for graphs and data visualisations should consist of the following:
What Amy Cesal's guide achieves is prompting an author to reflect on their reasons for including the graph or visualisation. What idea does this support? What can a reader learn or understand from this visual? The Graphs section of Diagram Center's guidance is also useful. Some key points (relevant to all graph types) we can take away from it are:
For general images, Harvard's guidance notes some useful ideas. A key point is to keep descriptions simple, and adapt them to the context and purpose for which the image is being included. Would you feel comfortable making a second draft of the alt-text for each of the figures? This is certainly a bit time-consuming, but we believe it is very worthwhile in terms of making your translation accessible to the broadest possible audience. We would be very grateful for your support with this. Thank you ✨ |
Hello Alberto @asmartinez and Eime Javier @zizneroz,, What's happening now?Your lesson has been moved to the next phase of our workflow which is Phase 3: Revision 1. This phase is an opportunity for you to revise your draft in response to @giuliataurino's initial feedback. I've checked to ensure that you both have the 'write access' you'll need to edit your draft directly. Please continue to make direct commits to your file here: en/drafts/translations/corpus-analysis-voyant-tools.md. @charlottejmc and I can help if you encounter any practical problems! When both of you & Giuila are all happy with the revised draft, we will move forward to Phase 4: Open Peer Review. %%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
'cScale1': '#882b4f', 'cScaleLabel1': '#ffffff',
'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
} } }%%
timeline
Section Phase 2 <br> Initial Edit
Who worked on this? : Editor (@giuliataurino)
All Phase 2 tasks completed? : Yes
Section Phase 3 <br> Revision 1
Who's working on this? : Authors (@asmartinez + @zizneroz)
Expected completion date? : July 28
Section Phase 4 <br> Open Peer Review
Who's responsible? : Reviewers (TBC)
Expected timeframe? : ~60 days after request is accepted
|
Hi @asmartinez and @zizneroz, As we approach the round of revisions, I wanted to check in with you to make sure that you have implemented the initial edits. If so, I will add the two reviewers to this issue so that they can start reviewing the translation. For everybody's reference, I will be out of the office the first two weeks of August. Thank you all for your work! Giulia |
Hello Gulia,
I spoke with Javier and he told me that he is still making some adjustments and expects to have everything done by the 28th. Does this work for you all?
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Giulia Taurino ***@***.***>
Sent: Tuesday, July 23, 2024 10:56:04 AM
To: programminghistorian/ph-submissions ***@***.***>
Cc: Alberto Santiago Martínez ***@***.***>; Mention ***@***.***>
Subject: Re: [programminghistorian/ph-submissions] Corpus Analysis with Voyant Tools (translation from Spanish) (Issue #608)
Hi @asmartinez<https://github.com/asmartinez> and @zizneroz<https://github.com/zizneroz>,
As we approach the round of revisions, I wanted to check in with you to make sure that you have implemented the initial edits. If so, I will add the two reviewers to this issue so that they can start reviewing the translation.
For everybody's reference, I will be out of the office the first two weeks of August.
Thank you all for your work!
Best,
Giulia
—
Reply to this email directly, view it on GitHub<#608 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFM564O32LQIGPH7KMMOH43ZN2DJ3AVCNFSM6AAAAABE527MQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVG42TSMBYGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Thank you, Alberto @asmartinez! It would be wonderful if, as you and Javier @zizneroz finalise your Phase 3 revisions, you could go through Charlotte's and Giulia's checklists of tasks/questions and check off those you have resolved. This will be a great help to @giuliataurino when it comes to re-reading your draft, and confirming if it is ready to move onwards to Phase 4 Open Peer Review. Please let us know if you have any questions. We are here to help 👐🏼 |
Hi Anisa (@anisa-hawes), Giulia (@giuliataurino) and Charlotte (@charlottejmc) We’ve finished making the changes based on the feedback we received and marked the completed ones in the checklist. We just have one question about this comment: We’re not sure which screenshot this refers to since there are several in that section. Also, no term is actually selected. The section is just meant to show the parts of Voyant Tools. |
Thank you for your work on these revisions, Javier @zizneroz! I'd like to ask if you could also revisit Charlotte's checklist earlier in this thread, and check off the tasks/questions you've resolved there. In particular, I notice that you haven't yet developed the Hello Giulia, @giuliataurino - Could you confirm which figure you felt was problematic/cropped incorrectly within the section titled Exploring the Corpus? (I wonder if it might have been Figure 8., where the words Average Word Per Sentence are partially obscured within the summary?) |
Hi!, Anisa (@anisa-hawes) Thanks for the feedback! I've gone ahead and updated the alt-texts to be more descriptive, so they better explain what each figure is showing. I also went through Charlotte's checklist and checked off the tasks that are done. Let me know if there's anything else that needs tweaking or if I missed something! |
Hi @anisa-hawes, I believe it was figure 9 (where the term column doesn't show the term), but I do see a sentence cropped in figure 8 as well.
|
Hi @zizneroz and @asmartinez, Hope you are well! Now that you are almost done with Phase 3 - Revision 1, I'd like to introduce you to the two reviewers, @marisolam and @betovargas - welcome! -, who kindly accepted to revise your translation. Let us know when the submission is correctly edited and ready for the open peer review so that we can officially start Phase 4 of the editing process. I remain available should you have further questions. Best, Giulia |
Hi all, I hope you enjoyed some time off this summer! I'm back to this thread to check on the status of the translation. On our end, we are waiting for the authors to confirm that the submission is ready for review before starting Phase 4. Again, @marisolam and @betovargas kindly accepted to review the translation, so I wanted to make sure they have a sense of how long it might take before they can start reviewing. Thank you all in advance! Best, Giulia |
Hi @giuliataurino, Thanks for the introduction and for setting this up! We’ve made all the suggested changes, and everything’s good to go. The document is ready for the open peer review, and we’re all set for the next phase. Let me know if there’s anything else we need to look at! Best, |
Hello Alberto @asmartinez and Javier @zizneroz, What's happening now?Your lesson has been moved to the next phase of our workflow which is Phase 4: Open Peer Review. This phase is an opportunity for you to hear feedback from peers in the community. Giulia @giuliataurino has invited two reviewers to read your translation, test your code, and provide constructive feedback. In the spirit of openness, reviews will be posted as comments in this issue (unless you specifically request a closed review). After both reviews, Giulia will summarise the suggestions to clarify your priorities in Phase 5: Revision 2. %%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
'cScale1': '#882b4f', 'cScaleLabel1': '#ffffff',
'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
} } }%%
timeline
Section Phase 3 <br> Revision 1
Who worked on this? : Authors (@asmartinez + @zizneroz)
All Phase 3 tasks completed? : Yes
Section Phase 4 <br> Open Peer Review
Who's working on this? : Reviewers (@marisolam + @betovargas)
Expected completion date? : November 1
Section Phase 5 <br> Revision 2
Who's responsible? : Authors (@asmartinez + @zizneroz)
Expected timeframe? : ~30 days after editor's summary
|
Hello @zizneroz, I can see in the images folder that you've left in the Thank you! |
Hi @charlottejmc , Sure, go ahead and delete them to keep the directory clean. |
Open Peer ReviewDuring Phases 2 and 3, I provided initial feedback on this translation, then worked with Alberto @asmartinez and Eime Javier @zizneroz to complete a first round of revisions. In Phase 4 Open Peer Review, we invite feedback from others in our community. So welcome again @marisolam and @betovargas. By participating in this peer review process, you are contributing to the creation of a useful and sustainable technical resource for the whole community. Thank you. Please read the lesson/translation, test the code, and post your review as a comment in this issue by November 1st, 2024. Reviewer Guidelines: A preview of the lesson: --
Best, Giulia |
Dear @asmartinez and @zizneroz, I hope you are doing well and I want to say great job translating this voyant tutorial. Reading the original and comparing it with your translation I saw how labor intensive it is to both translate narrative, technical and intructional text while creating new examples at the same time. Given all that, I wanted to point out that my suggestions below are just that, suggestions. Aside from a couple of grammatical corrections, most of my suggestions below point to a possible "clearer" way of translating the text. Since clarity is highly subjective, you can judge accordingly. I am happy to answer any questions you may have. IntroductionPhrase: "In this sense, this text can be considered as one of the options for corpus analysis you can find in PH" Corpus AnalysisPhrase: "software to appreciate patterns" Phrase: "For example, to obtain usage and decline patterns" Creating a plain text corpusPhrase:"does not require extra knowledge" Number of text, words, and unique wordsPhrase:"In the following lines, you will find nine activities that can be resolved..." Phrase:"The last four are open to reflection/discussion by those who carry them out" Words per sentencePhrase: "Very approximate" Stop words - Activity 6Phrase: "apply to all" Frequencies with filtered stop wordsPhrase: "Apply to all" is here again. Statistical skewnessPhrase: "The closer to zero the degree of statistical skewness" Activity Answers - Activity 2Phrase: "We might observe, for example, that the longest texts are the sixth, eighth Annual Message to Congress" Activity 3Phrase: "There seems to be a correspondence between shorter and denser speeches, which is natural since the shorter a text is, the less "opportunity" there is to repeat." |
Thank you for your thoughtful review of this translation, Roberto @betovargas! -- Hello Alberto @asmartinez and Javier @zizneroz, Just a quick reminder that it is important to wait until both reviews are received before beginning to implement changes. When both reviews are in, Giulia @giuliataurino will summarise them to clarify your priorities for Phase 5 revisions. Thank you for your patience 🙂 |
Hi all, A quick update on issue #608: I believe at this stage we are waiting for @marisolam's review. Once we receive the second reviewer's feedback, we can move onto Phase 5 - revisions and complete the editorial process for this submission. Feel free to reach out should you have further questions. Best, Giulia |
Dear all, I confirm @marisolam's review is underway. Thank you for your patience. Best, Giulia |
Hello everyone, I owe you a huge apology for my lateness on this. Confirming that my review will be posted by the end of the month. Best, Marisol |
Programming Historian in English has received a proposal for a translation from Spanish of "Corpus Analysis with Voyant Tools" by @asmartinez and @zizneroz.
I have circulated this proposal for feedback within the English team. We have considered this proposal for:
We are pleased to have invited @asmartinez and @zizneroz to develop this Proposal into a Submission under the guidance of @giuliataurino as editor.
The Submission package should include:
We ask @asmartinez to share their Submission package with our Publishing team by email, copying in @giuliataurino.
We've agreed a submission date of April. We ask @asmartinez and @zizneroz to contact us if they need to revise this deadline.
When the Submission package is received, our Publishing team will process the new lesson materials, and prepare a Preview of the initial draft. They will post a comment in this Issue to provide the locations of all key files, as well as a link to the Preview where contributors can read the lesson as the draft progresses.
If we have not received the Submission package by April, @giuliataurino will attempt to contact @asmartinez and @zizneroz. If we do not receive any update, this Issue will be closed.
Our dedicated Ombudspersons are Ian Milligan (English), Silvia Gutiérrez De la Torre (español), Hélène Huet (français), and Luis Ferla (português) Please feel free to contact them at any time if you have concerns that you would like addressed by an impartial observer. Contacting the ombudspersons will have no impact on the outcome of any peer review.
The text was updated successfully, but these errors were encountered: