Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corpus Analysis with Voyant Tools (translation from Spanish) #608

Open
hawc2 opened this issue Mar 19, 2024 · 30 comments
Open

Corpus Analysis with Voyant Tools (translation from Spanish) #608

hawc2 opened this issue Mar 19, 2024 · 30 comments

Comments

@hawc2
Copy link
Collaborator

hawc2 commented Mar 19, 2024

Programming Historian in English has received a proposal for a translation from Spanish of "Corpus Analysis with Voyant Tools" by @asmartinez and @zizneroz.

I have circulated this proposal for feedback within the English team. We have considered this proposal for:

  • Openness: we advocate for use of open source software, open programming languages and open datasets
  • Global access: we serve a readership working with different operating systems and varying computational resources
  • Multilingualism: we celebrate methodologies and tools that can be applied or adapted for use in multilingual research-contexts
  • Sustainability: we're committed to publishing learning resources that can remain useful beyond present-day graphical user interfaces and current software versions

We are pleased to have invited @asmartinez and @zizneroz to develop this Proposal into a Submission under the guidance of @giuliataurino as editor.

The Submission package should include:

  • Lesson text (written in Markdown)
  • Figures: images / plots / graphs (if using)
  • Data assets: codebooks, sample dataset (if using)

We ask @asmartinez to share their Submission package with our Publishing team by email, copying in @giuliataurino.

We've agreed a submission date of April. We ask @asmartinez and @zizneroz to contact us if they need to revise this deadline.

When the Submission package is received, our Publishing team will process the new lesson materials, and prepare a Preview of the initial draft. They will post a comment in this Issue to provide the locations of all key files, as well as a link to the Preview where contributors can read the lesson as the draft progresses.

If we have not received the Submission package by April, @giuliataurino will attempt to contact @asmartinez and @zizneroz. If we do not receive any update, this Issue will be closed.

Our dedicated Ombudspersons are Ian Milligan (English), Silvia Gutiérrez De la Torre (español), Hélène Huet (français), and Luis Ferla (português) Please feel free to contact them at any time if you have concerns that you would like addressed by an impartial observer. Contacting the ombudspersons will have no impact on the outcome of any peer review.

@anisa-hawes anisa-hawes moved this to 0 Proposal in Active Lessons Mar 19, 2024
@anisa-hawes anisa-hawes changed the title Corpus Analysis with Voyant Tools (translation from French) Corpus Analysis with Voyant Tools (translation from Spanish) Apr 5, 2024
@charlottejmc
Copy link
Collaborator

charlottejmc commented Jun 12, 2024

Hello @giuliataurino, @asmartinez and @zizneroz,

You can find the key files here:

You can review a preview of the lesson here:


Thank you for your submission @asmartinez and @zizneroz.

  • I have made some adjustments to remove a number of subheadings from the Table of Contents, which was originally longer than we prefer, and felt a little too cluttered. The subheadings still appear in the lesson, but usually as bold or - bullet points, rather than ## Markdown Headings.

  • I saved 18 images from the links I found in the markdown file, and reinserted them using our liquid syntax, which looks like this:

{% include figure.html filename="file-name-1.png" alt="Visual description of figure image" caption="Figure 1. Caption text to display" %}
  • I have replaced Figure 15 (the mathematical equation) with a formula in Latex instead. This reduces the figure count to 17 instead of 18.

  • Could I ask you to provide both the caption and the alt-text ("Visual description of figure image") for all the remaining figures? I can provide some guidance about writing alt-text if you would like.

  • I have a query about the assets associated with this translation. We would like to host all the associated asset files that users will need to follow the lesson, in order to ensure its sustainability. The original lesson's assets contain a zip file of the presidential speeches, a selection of some of the speeches in a separate folder, and a stopwords-es.txt file. I understand from your lesson that you are using instead "a corpus of President George Washington's Annual Messages to Congress". However, the Zenodo link you shared at line 71 points to the original set of Spanish language speeches. Could you please provide the corpus you are referring to in this lesson, as well as any additional assets you might need? For example, the lesson also lists a number of speeches under Activity 8 – we could also host these individually on GitHub. I also see that you link to a stopwords file on your own repo.

  • Could you please confirm what parts of the text the 3 footnotes at the very end of the lesson refer to?

Thank you! ✨

@anisa-hawes anisa-hawes moved this from 0 Proposal to 1 Submission in Active Lessons Jun 13, 2024
@anisa-hawes anisa-hawes moved this from 1 Submission to 2 Initial Edit in Active Lessons Jun 13, 2024
@anisa-hawes
Copy link
Contributor

Hello Alberto @asmartinez and Eime Javier @zizneroz,

What's happening now?

Your lesson has been moved to the next phase of our workflow which is Phase 2: Initial Edit.

In this phase, your editor Editor @giuliataurino will read your lesson, and provide some initial feedback. Giulia will post feedback and suggestions as a comment in this issue, so that you can revise your draft in the following phase (Phase 3: Revision 1).

%%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
              'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
              'cScale1': '#882b4f', 'cScaleLabel1': '#ffffff',
              'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
       } } }%%
timeline
Section Phase 1 <br> Submission
Who worked on this? : Publishing Assistant (@charlottejmc) 
All  Phase 1 tasks completed? : Yes
Section Phase 2 <br> Initial Edit
Who's working on this? : Editor (@giuliataurino)  
Expected completion date? : July 14
Section Phase 3 <br> Revision 1
Who's responsible? : Authors (@asmartinez + zizneroz) 
Expected timeframe? : ~30 days after feedback is received
Loading

Note: The Mermaid diagram above may not render on GitHub mobile. Please check in via desktop when you have a moment.

@anisa-hawes
Copy link
Contributor

anisa-hawes commented Jun 13, 2024

Hello again Alberto @asmartinez and Eime Javier @zizneroz,

I've sent you each an invitation to join us as Outside Collaborators here on GitHub. This will give you the 'write access' you'll need to add your figure captions and alt-text as Charlotte suggests above. Your lesson file is here: /en/drafts/translations/corpus-analysis-voyant-tools.md, and you can edit it directly.

The original lesson was published before we introduced a requirement for alt-text to support all figures, so we will need to ask you to write the visual descriptions of each figure. However, you can translate / or adapt the captions from the Spanish original as follows:

  1. caption="Guardar en UTF-8 en Windows: 1) Abrir Bloc de Notas, 2) Después de pegar o escribir el texto, dar clic en 'Guardar como' 3) En la ventana de 'codificiación' seleccionar 'UTF-8' 4) Elegir nombre de archivo y guardar como .txt (Torresblanca, 2014)"
  2. caption="Guardar en UTF-8 en Mac: 1) Abrir TextEdit 2) Pegar el texto que se desea guardar 3) Convertir a texto plano (opcin en el menú de 'Formato') 4) Al guardar, seleccionar el encoding 'UTF-8' (Creative Corner, 2016)"
  3. caption="Guardar en UTF-8 en Ubuntu: 1) Abrir Gedit 2) Después de pegar el texto, al guardar, seleccionar 'UTF-8' en la ventana de 'Codificación de caracteres'"
  4. caption="Cargar documentos"
  5. caption="Cirrus"
  6. caption="Lector"
  7. caption="Tendencias"
  8. caption="Sumario"
  9. caption="Contextos"
  10. caption="Abrir opciones"
  11. caption="Editar lista"
  12. caption="Quitar palabras vacías"
  13. caption="Frecuencia relativa"
  14. caption="Asimetría estadística"
  15. `caption="Agregar columna de posición"
  16. caption="Exportar contextos"
  17. caption="Importar datos desde un archivo de textos"

With many thanks,
Anisa

@giuliataurino
Copy link
Contributor

  • I have made some adjustments to remove a number of subheadings from the Table of Contents, which was originally longer than we prefer, and felt a little too cluttered. The subheadings still appear in the lesson, but usually as bold or - bullet points, rather than ## Markdown Headings.

Hi @charlottejmc,

Thank you for uploading the translation and making the necessary edits. Should I then direct reviewers to ignore the different in the subheadings titles and structure and focus on the content of the paragraphs only?

Best,

Giulia

@giuliataurino
Copy link
Contributor

giuliataurino commented Jun 20, 2024

Hi Alberto @asmartinez and Eime Javier @zizneroz,

Thank you for taking upon this translation and the additional work required for adapting the examples and new formatting guidelines.

Overall, the translation looks good. In the next few points, I will share a lot of notes and suggestions that are fairly common edits in first draft translations. Bear in mind that not all changes are needed some are questions or suggestions, some of them are reminder of what @anisa-hawes and @charlottejmc already pointed at in previous comments, and few might be notes for the editorial team itself (Anisa and Charlotte, I'll let you make the call on which edits should be taken upon by the editorial team). Despite the number of comments below, I want to reiterate that the quality of the translation is good and we much appreciated your work to make this original submission accessible to non-Spanish speakers.

Introduction

  • verify that "decaimiento" correctly translates as "decay" in the context of textual analysis (or else, is it more accurate to translated the original term with "loss", "decline"?);
  • "dada epoca" is translated with "given era". While this sounds correct to me, would it be better to translate as "at/in a given time" in the English wording?
  • "muy pronto" is translated as "very soon"; consider other idioms used in English with the same meaning (e.g., "early on" perhaps?);
  • "no tardaron" is translated as "quickly"; consider translating with "promptly" instead.

Creating a Plain Text Corpus

  • the dates/timespan of the corpus in the adapted case study are missing;
  • "primera palabra dicha" = translate as "first spoken word", as opposed to "first word spoken";
  • (!) This is a recurring, inconsistent formatting issue throughout the text and recurs in almost all tables from now on and might need the intervention of @anisa-hawes or @charlottejmc : paragraph 12 is missing the table formatting; [Publishing Team]
  • I noticed errors in the numbering of the lists of steps to save plain text in UTF8 (there are two bullet points 1. for each example); [Publishing Team]
  • (!) This applies to all figures from now on: remember to translate the caption of each figure and add it to the document as noted in @anisa-hawes' comment above;
  • p. 18-19: "...should not contain accents or spaces" should perhaps be translated as "should not contain accents nor spaces".

Loading the Corpus

  • p. 25: to my knowledge, the English version of Voyant used the button "Upload" not "Load". Please verify this and correct the translation accordingly + consider using the verb "upload" instead of "load" even in other instances where the original term "cargar" appears.

Exploring the corpus

  • p. 32: unfortunately, in the screenshot the term chosen as an example is cut off. Add a new screenshot where the term is visibile and readable. @zizneroz, please send this new image to Charlotte at publishing.assistant[@]programminghistorian.org

Document summary: basic characteristics of your set of text

  • p. 33: the Spanish idiom "una vista de pájaro" - here translated literally with "bird's eye view" - better translates with "overview";
  • p. 45: bullet points should probably be separated and returned on different lines? (confirm with the editorial team); [Publishing Team]
  • p. 46: "The closer the index" - where "...index" misses the word "density" from the original translation - should be "the closer the density index";
  • from p. 48 on: should the songs be adapted to an English song example, rather than translated?
  • p. 58: question 1 might need to be adapted to the newly selected English corpus for this example (particularly when it comes to the metadata appearing in the English corpus filenames)
  • + bullet list should probably be separated by a line. [Publishing Team]

Cirrus and summary: frequencies and stop word filters

  • p. 63, 67: use separation line between bullet points; [Publishing Team]
  • p. 65: "justo por esto" might be better translated with "for this very reason" instead of "just for this reason";
  • p. 68: the text is erroneously translated word by word without adapting to English - where "Voyant already has a stop word list loaded for Spanish" should be instead translated with "Voyant already has a stop word list loaded for English";

Terms

  • p. 79: consider transforming the phrase from passive to active for a smoother reading in English, such as "The following section will explore...";
  • p. 80: please note that the phrase from the song translated from Spanish to English counts 7 (not 8) words. Either change the example itself with an English song (cf. p. 48) or translate the sentence by updating the correct word count to 7;
  • p. 81: translate the word "corazón" to English ("heart") or replace with the English word based on the example given in p. 48 + update numbers and calculations to the correct ones based on the example in p. 48 (cf. p. 80, if the translation from the Spanish example is kept, then divide by 7, not 8; if not, update the word count based on the example you choose to provide);
  • p. 81: the punctuation seems incorrect to me in a few instances of the original version. Here, I would replace ";" with a comma "," - as in, "xxxx occurrences out of xxxx words, while the gross frequency";
  • p. 82-83: add bullet list? (this might be a question for @anisa-hawes and @charlottejmc, was this changed on purpose from the original for editorial reasons?) [Publishing Team]
  • p. 83: the original version is "Contar (con la ‘frecuencia bruta o neta’ de cada término)", whereas the translation only mentions "gross frequency". Was there an error in the original version or the translation missed the term "net"? If the latter is true, then the translation should probably be "Count (with the ‘gross or net frequency’ of each term)";
  • p. 85: adapt the translation to consider the new English corpus (which does not seem to include different countries);
  • p. 88/Figure 14: might be worth adding a reference to the median value in the visualization, just like in the original image;
  • p. 89: make sure this example is still giving the same skewness in the adapted translation;
  • p. 92-93: missing space between the lines in the bullet list; [Publishing Team]
  • p. 94: missing all links and missing the spaces between the lines in the bullet list. [Publishing Team]

Words in context

  • p. 96: "left and right concordance" is not translated - "en la ventana de “Contextos” es posible hacer consultas de las concordancias izquierdas y derechas de términos específicos" should perhaps be "in the “Contexts” window, it is possible to make left and right concordance queries of specific terms";
  • p. 100: missing translation in the table section for "Consulta avanzada" + suffix “ción” needs to be adapted in the translation to "th" + add adapted example for "country precarious" (cf. original Spanish version's example: "esa condición regresaría frases cómo “la extrema desigualdad y la pobreza” donde se encuentra la palabra “pobreza” y “extrema”");
  • + missing table formatting -[Publishing Team]
  • p. 101: add numbered list as in original + translate "Cuidado" to "Attention" in the table unless this is a change by the editorial team
  • (@anisa-hawes and @charlottejmc, could you also verify that the table formatting is consistent in all sections? this formatting is different from other formatting both in the translation and in the original.). [Publishing Team]

Activity Answers

  • p. 108 to 115: adapt and update translation to English version (both the "unique words" - tengo, hambre, sueño - and all answers below that);
  • p. 117: add references and links to earlier sections as in the original version.

I remain available should you have any questions or doubts about these reviews.

Best,

Giulia

@zizneroz
Copy link
Collaborator

Hi Giulia (@giuliataurino),

Can you send me the Git collaboration invite again? The last one expired because I couldn't find it in my emails.

Best,

Eime

@anisa-hawes
Copy link
Contributor

anisa-hawes commented Jun 21, 2024

Hello Eime @zizneroz.

I already re-sent you the invitation to join us as an Outside Collaborator.

We ask authors to work on their own files with direct commits: we don't want you to use the Pull Request system, or fork our repo to edit in ph-submissions. You can make direct commits to your file here: en/drafts/translations/corpus-analysis-voyant-tools.md.

With thanks, Anisa.

@zizneroz
Copy link
Collaborator

Hi Anisa @anisa-hawes,

Got it.

I accepted the invite and I'll make the commits directly to the file.

Thank you!

@charlottejmc
Copy link
Collaborator

Hello @asmartinez, @zizneroz and @giuliataurino,

I just wanted to point out that I have edited Giulia's comment slightly to turn each point into a checkbox. This should help us keep track of which changes have been made, and which ones still need to be looked at!

You'll see that I have also added [Publishing Team] to several points – these are things @anisa-hawes and I will take care of ourselves.

Thank you!

@charlottejmc
Copy link
Collaborator

Hello again @zizneroz,

I saw from your commit that you have been working on the figure alt-text. Thank you! However, I think we will still need some more work to make them truly effective as 'alt-text'.

This descriptive element enables screen readers to read the information conveyed in the images for people with visual impairments, different learning abilities, or who cannot otherwise view them, for example due to a slow internet connection. It's important to say that alt-text should go further than repeating the figure captions.

We have found Amy Cesal's guide to Writing Alt Text for Data Visualization useful. This guide advises that alt-text for graphs and data visualisations should consist of the following:

alt="[Chart type] of [data type] where [reason for including chart]"

What Amy Cesal's guide achieves is prompting an author to reflect on their reasons for including the graph or visualisation. What idea does this support? What can a reader learn or understand from this visual?

The Graphs section of Diagram Center's guidance is also useful. Some key points (relevant to all graph types) we can take away from it are:

  • Briefly describe the graph and give a summary if one is immediately apparent
  • Provide any titles and axis labels
  • It is not necessary to describe the visual attributes of the graph (colour, shading, line-style etc.) unless there is an explicit need
  • Often, data shown in a graph can be converted into accessible tables

For general images, Harvard's guidance notes some useful ideas. A key point is to keep descriptions simple, and adapt them to the context and purpose for which the image is being included.

Would you feel comfortable making a second draft of the alt-text for each of the figures? This is certainly a bit time-consuming, but we believe it is very worthwhile in terms of making your translation accessible to the broadest possible audience. We would be very grateful for your support with this.

Thank you ✨

@anisa-hawes anisa-hawes moved this from 2 Initial Edit to 3 Revision 1 in Active Lessons Jun 27, 2024
@anisa-hawes
Copy link
Contributor

Hello Alberto @asmartinez and Eime Javier @zizneroz,,

What's happening now?

Your lesson has been moved to the next phase of our workflow which is Phase 3: Revision 1.

This phase is an opportunity for you to revise your draft in response to @giuliataurino's initial feedback. I've checked to ensure that you both have the 'write access' you'll need to edit your draft directly.

Please continue to make direct commits to your file here: en/drafts/translations/corpus-analysis-voyant-tools.md. @charlottejmc and I can help if you encounter any practical problems!

When both of you & Giuila are all happy with the revised draft, we will move forward to Phase 4: Open Peer Review.

%%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
              'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
              'cScale1': '#882b4f', 'cScaleLabel1': '#ffffff',
              'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
       } } }%%
timeline
Section Phase 2 <br> Initial Edit
Who worked on this? : Editor (@giuliataurino) 
All  Phase 2 tasks completed? : Yes
Section Phase 3 <br> Revision 1
Who's working on this? : Authors (@asmartinez + @zizneroz)  
Expected completion date? : July 28
Section Phase 4 <br> Open Peer Review
Who's responsible? : Reviewers (TBC) 
Expected timeframe? : ~60 days after request is accepted
Loading

Note: The Mermaid diagram above may not render on GitHub mobile. Please check in via desktop when you have a moment.

@giuliataurino
Copy link
Contributor

Hi @asmartinez and @zizneroz,

As we approach the round of revisions, I wanted to check in with you to make sure that you have implemented the initial edits. If so, I will add the two reviewers to this issue so that they can start reviewing the translation.

For everybody's reference, I will be out of the office the first two weeks of August.

Thank you all for your work!
Best,

Giulia

@asmartinez
Copy link

asmartinez commented Jul 23, 2024 via email

@anisa-hawes
Copy link
Contributor

Thank you, Alberto @asmartinez!

It would be wonderful if, as you and Javier @zizneroz finalise your Phase 3 revisions, you could go through Charlotte's and Giulia's checklists of tasks/questions and check off those you have resolved.

This will be a great help to @giuliataurino when it comes to re-reading your draft, and confirming if it is ready to move onwards to Phase 4 Open Peer Review.

Please let us know if you have any questions. We are here to help 👐🏼

@zizneroz
Copy link
Collaborator

Hi Anisa (@anisa-hawes), Giulia (@giuliataurino) and Charlotte (@charlottejmc)

We’ve finished making the changes based on the feedback we received and marked the completed ones in the checklist.

We just have one question about this comment:
Exploring the corpus
p. 32: unfortunately, in the screenshot the term chosen as an example is cut off. Add a new screenshot where the term is visible and readable. @zizneroz, please send this new image to Charlotte at publishing.assistant[@]programminghistorian.org

We’re not sure which screenshot this refers to since there are several in that section. Also, no term is actually selected. The section is just meant to show the parts of Voyant Tools.

@anisa-hawes
Copy link
Contributor

anisa-hawes commented Aug 1, 2024

Thank you for your work on these revisions, Javier @zizneroz!

I'd like to ask if you could also revisit Charlotte's checklist earlier in this thread, and check off the tasks/questions you've resolved there. In particular, I notice that you haven't yet developed the alt-text to accompanies each figure - which remains a repetition of the captions. We need to ensure this lesson will be accessible to those who are visually impaired and use screen-readers, so the alt-text must describe what the figures demonstrate. Charlotte has shared some advice and links to resources in her comment above.

Hello Giulia, @giuliataurino - Could you confirm which figure you felt was problematic/cropped incorrectly within the section titled Exploring the Corpus? (I wonder if it might have been Figure 8., where the words Average Word Per Sentence are partially obscured within the summary?)

@zizneroz
Copy link
Collaborator

Hi!, Anisa (@anisa-hawes)

Thanks for the feedback! I've gone ahead and updated the alt-texts to be more descriptive, so they better explain what each figure is showing. I also went through Charlotte's checklist and checked off the tasks that are done. Let me know if there's anything else that needs tweaking or if I missed something!

@giuliataurino
Copy link
Contributor

Hi @anisa-hawes,

I believe it was figure 9 (where the term column doesn't show the term), but I do see a sentence cropped in figure 8 as well.

Thank you for your work on these revisions, Javier @zizneroz!

I'd like to ask if you could also revisit Charlotte's checklist earlier in this thread, and check off the tasks/questions you've resolved there. In particular, I notice that you haven't yet developed the alt-text to accompanies each figure - which remains a repetition of the captions. We need to ensure this lesson will be accessible to those who are visually impaired and use screen-readers, so the alt-text must describe what the figures demonstrate. Charlotte has shared some advice and links to resources in her comment above.

Hello Giulia, @giuliataurino - Could you confirm which figure you felt was problematic/cropped incorrectly within the section titled Exploring the Corpus? (I wonder if it might have been Figure 8., where the words Average Word Per Sentence are partially obscured within the summary?)

@giuliataurino
Copy link
Contributor

Hi @zizneroz and @asmartinez,

Hope you are well!

Now that you are almost done with Phase 3 - Revision 1, I'd like to introduce you to the two reviewers, @marisolam and @betovargas - welcome! -, who kindly accepted to revise your translation.

Let us know when the submission is correctly edited and ready for the open peer review so that we can officially start Phase 4 of the editing process.

I remain available should you have further questions.

Best,

Giulia

@giuliataurino
Copy link
Contributor

Hi all,
(@zizneroz, @asmartinez, @anisa-hawes, @charlottejmc)

I hope you enjoyed some time off this summer! I'm back to this thread to check on the status of the translation.

On our end, we are waiting for the authors to confirm that the submission is ready for review before starting Phase 4. Again, @marisolam and @betovargas kindly accepted to review the translation, so I wanted to make sure they have a sense of how long it might take before they can start reviewing.

Thank you all in advance!

Best,

Giulia

@zizneroz
Copy link
Collaborator

zizneroz commented Sep 3, 2024

Hi @giuliataurino,

Thanks for the introduction and for setting this up!

We’ve made all the suggested changes, and everything’s good to go. The document is ready for the open peer review, and we’re all set for the next phase.

Let me know if there’s anything else we need to look at!

Best,
Eime

@anisa-hawes anisa-hawes moved this from 3 Revision 1 to 4 Open Peer Review in Active Lessons Sep 4, 2024
@anisa-hawes
Copy link
Contributor

anisa-hawes commented Sep 4, 2024

Hello Alberto @asmartinez and Javier @zizneroz,

What's happening now?

Your lesson has been moved to the next phase of our workflow which is Phase 4: Open Peer Review.

This phase is an opportunity for you to hear feedback from peers in the community.

Giulia @giuliataurino has invited two reviewers to read your translation, test your code, and provide constructive feedback. In the spirit of openness, reviews will be posted as comments in this issue (unless you specifically request a closed review).

After both reviews, Giulia will summarise the suggestions to clarify your priorities in Phase 5: Revision 2.

%%{init: { 'logLevel': 'debug', 'theme': 'dark', 'themeVariables': {
              'cScale0': '#444444', 'cScaleLabel0': '#ffffff',
              'cScale1': '#882b4f', 'cScaleLabel1': '#ffffff',
              'cScale2': '#444444', 'cScaleLabel2': '#ffffff'
       } } }%%
timeline
Section Phase 3 <br> Revision 1
Who worked on this? : Authors (@asmartinez + @zizneroz)
All  Phase 3 tasks completed? : Yes
Section Phase 4 <br> Open Peer Review
Who's working on this? : Reviewers (@marisolam + @betovargas)
Expected completion date? : November 1
Section Phase 5 <br> Revision 2
Who's responsible? : Authors (@asmartinez + @zizneroz)
Expected timeframe? : ~30 days after editor's summary
Loading

Note: The Mermaid diagram above may not render on GitHub mobile. Please check in via desktop when you have a moment.

@charlottejmc
Copy link
Collaborator

Hello @zizneroz,

I can see in the images folder that you've left in the _old versions of images 08 and 09 (alongside their new versions). I would just like to check with you whether I can delete the old versions to tidy up the directory?

Thank you!

@zizneroz
Copy link
Collaborator

zizneroz commented Sep 5, 2024

Hi @charlottejmc ,

Sure, go ahead and delete them to keep the directory clean.

@giuliataurino
Copy link
Contributor

giuliataurino commented Sep 5, 2024

Open Peer Review

During Phases 2 and 3, I provided initial feedback on this translation, then worked with Alberto @asmartinez and Eime Javier @zizneroz to complete a first round of revisions.

In Phase 4 Open Peer Review, we invite feedback from others in our community.

So welcome again @marisolam and @betovargas. By participating in this peer review process, you are contributing to the creation of a useful and sustainable technical resource for the whole community. Thank you.

Please read the lesson/translation, test the code, and post your review as a comment in this issue by November 1st, 2024.

Reviewer Guidelines:

A preview of the lesson:

--
Notes:

  • All participants in this discussion are advised to read and be guided by our shared Code of Conduct.
  • Members of the wider community may also choose to contribute reviews.
  • All participants must adhere to our anti-harassment policy:

Anti-Harassment Policy

This is a statement of the Programming Historian's principles and sets expectations for the tone and style of all correspondence between reviewers, authors, editors, and contributors to our public forums.

Programming Historian in English is dedicated to providing an open scholarly environment that offers community participants the freedom to thoroughly scrutinize ideas, to ask questions, make suggestions, or request clarification, but also provides a harassment-free space for all contributors to the project, regardless of gender, gender identity and expression, sexual orientation, disability, physical appearance, body size, race, age or religion, or technical experience. We do not tolerate harassment or ad hominem attacks of community participants in any form. Participants violating these rules may be expelled from the community at the discretion of the editorial board. If anyone witnesses or feels they have been the victim of the above described activity, please contact our ombudsperson Dr Ian Milligan. Thank you for helping us to create a safe space.

Best,

Giulia

@betovargas
Copy link

betovargas commented Oct 9, 2024

Dear @asmartinez and @zizneroz,

I hope you are doing well and I want to say great job translating this voyant tutorial. Reading the original and comparing it with your translation I saw how labor intensive it is to both translate narrative, technical and intructional text while creating new examples at the same time. Given all that, I wanted to point out that my suggestions below are just that, suggestions. Aside from a couple of grammatical corrections, most of my suggestions below point to a possible "clearer" way of translating the text. Since clarity is highly subjective, you can judge accordingly. I am happy to answer any questions you may have.

Introduction

Phrase: "In this sense, this text can be considered as one of the options for corpus analysis you can find in PH"
Suggestion: The word "tutorial" instead of "text" might give a better description of what this is. I know the word "texto" was use in spanish but given the spcialized use of the word "text" during this tutorial, it might make more sense to use tutorial

Corpus Analysis

Phrase: "software to appreciate patterns"
Suggestion: The use of of the word "apreciar" in the spanish version: "han creado y utilizado software para apreciar patrones que no son evidentes" seems to be better translated as "consider", "notice" or "identify" since the spanish text is using "apreciar" not in the sense of "liking" but in the sense of noticing.

Phrase: "For example, to obtain usage and decline patterns"
Suggestion: Awkward sentence because of the original text. I might be misunderstanding but the original text in spanish seems to be missing the word aumento ("patrones de (aumento) de uso y decaimiento.").

Creating a plain text corpus

Phrase:"does not require extra knowledge"
Suggestion: Might be helpful to clarify "extra knowledge" of what. Exampe: "Does not require extra knowledge of text analysis" "or voyant"

Number of text, words, and unique words

Phrase:"In the following lines, you will find nine activities that can be resolved..."
Suggestion:"in the following lines" reads better as just "Below, you will find" even though the spanish text does have "en las lineas the abajo"

Phrase:"The last four are open to reflection/discussion by those who carry them out"
Suggestion: It might be more clearer translated like "The remaining four activities are designed to encourage reflection and discussion among participants who engage with them."

Words per sentence

Phrase: "Very approximate"
Suggestion: would be better translated "as a rough estimate."

Stop words - Activity 6

Phrase: "apply to all"
Suggestion: wording in voyant is now "apply globaly"

Frequencies with filtered stop words

Phrase: "Apply to all" is here again.
Sugestion: Button is now labeled "Apply globably

Statistical skewness

Phrase: "The closer to zero the degree of statistical skewness"
Suggestion:Missing an "is" at the end. "The closer to zero the degree of statistical skewness is"

Activity Answers - Activity 2

Phrase: "We might observe, for example, that the longest texts are the sixth, eighth Annual Message to Congress"
Suggestion: needs an "and" between sixth and eight.

Activity 3

Phrase: "There seems to be a correspondence between shorter and denser speeches, which is natural since the shorter a text is, the less "opportunity" there is to repeat."
Suggestion: might be better translated as "the less "opportunity" there is for words to repeat"

@anisa-hawes
Copy link
Contributor

Thank you for your thoughtful review of this translation, Roberto @betovargas!

--

Hello Alberto @asmartinez and Javier @zizneroz,

Just a quick reminder that it is important to wait until both reviews are received before beginning to implement changes.

When both reviews are in, Giulia @giuliataurino will summarise them to clarify your priorities for Phase 5 revisions. Thank you for your patience 🙂

@giuliataurino
Copy link
Contributor

Hi all,

A quick update on issue #608: I believe at this stage we are waiting for @marisolam's review. Once we receive the second reviewer's feedback, we can move onto Phase 5 - revisions and complete the editorial process for this submission.

Feel free to reach out should you have further questions.

Best,

Giulia

@giuliataurino
Copy link
Contributor

giuliataurino commented Dec 5, 2024

Dear all,

I confirm @marisolam's review is underway.

Thank you for your patience.

Best,

Giulia

@marisolam
Copy link

Hello everyone,

I owe you a huge apology for my lateness on this. Confirming that my review will be posted by the end of the month.

Best,

Marisol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 4 Open Peer Review
Development

No branches or pull requests

8 participants