Skip to content

Commit 34ccb16

Browse files
committed
Only Skip if needed
* Sometimes Skip() can produce less efficient SQL queries
1 parent 0c213f3 commit 34ccb16

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

Build/CommonAssemblyInfo.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@
1515
//
1616
// You can specify all the values or you can default the Revision and Build Numbers
1717
// by using the '*' as shown below:
18-
[assembly: AssemblyVersion("3.6.40")]
19-
[assembly: AssemblyFileVersion("3.6.40")]
18+
[assembly: AssemblyVersion("3.6.41")]
19+
[assembly: AssemblyFileVersion("3.6.41")]
2020
//[assembly: AssemblyInformationalVersion("2.5-filters")]

Griddly.Mvc/Results/QueryableResult.cs

+4-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,10 @@ public override IList<T> GetPage(int pageNumber, int pageSize, SortField[] sortF
5959
if (_massage != null)
6060
sortedQuery = _massage(sortedQuery);
6161

62-
return sortedQuery.Skip(pageNumber * pageSize).Take(pageSize).ToList();
62+
if (pageNumber != 0)
63+
sortedQuery = sortedQuery.Skip(pageNumber * pageSize);
64+
65+
return sortedQuery.Take(pageSize).ToList();
6366
}
6467

6568
public override void PopulateSummaryValues(GriddlySettings<T> settings)

0 commit comments

Comments
 (0)