From 8dac2bbea54837409cc982836505612ef994dedd Mon Sep 17 00:00:00 2001
From: amandesai01 <amandesai01@gmail.com>
Date: Tue, 10 Sep 2024 19:26:28 +0530
Subject: [PATCH] fix(auth): fix no session bug

---
 app/components/admin/MemberCard.vue | 2 +-
 app/composables/auth.ts             | 4 ++--
 app/composables/state.ts            | 2 +-
 app/middleware/admin-auth.ts        | 2 +-
 app/pages/admin/dashboard.vue       | 2 +-
 server/api/userinfo.ts              | 3 ++-
 6 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/app/components/admin/MemberCard.vue b/app/components/admin/MemberCard.vue
index f1569ed..d85a64e 100644
--- a/app/components/admin/MemberCard.vue
+++ b/app/components/admin/MemberCard.vue
@@ -29,7 +29,7 @@ const onRemove = () => {
         title="Remove Member?"
         confirmLabel="Remove"
         content="Member's access will be immediatly disabled. No actions performed by member will be reverted."
-        v-if="profile.id != member.id"
+        v-if="profile?.id != member.id"
       >
         <template #input="{ open }">
           <InputButton variant="destructive" size="icon" @click="open">
diff --git a/app/composables/auth.ts b/app/composables/auth.ts
index 6bcdf27..e875a9e 100644
--- a/app/composables/auth.ts
+++ b/app/composables/auth.ts
@@ -1,7 +1,7 @@
 export function useAuth() {
   const session = useSessionState();
-  const isSignedIn = computed(() => !!session.value.profile);
-  const profile = computed(() => session.value.profile);
+  const isSignedIn = computed(() => !!session.value?.profile);
+  const profile = computed(() => session.value?.profile);
 
   return {
     session,
diff --git a/app/composables/state.ts b/app/composables/state.ts
index 80495ba..7973363 100644
--- a/app/composables/state.ts
+++ b/app/composables/state.ts
@@ -2,7 +2,7 @@ import { type CareerSiteConfig, type SEOConfig } from '~~/shared/schemas/setting
 import type { Session } from '~~/shared/types/profile-types';
 
 export function useSessionState() {
-  return useState<Session>('oauth_session');
+  return useState<Session | null>('oauth_session');
 }
 
 export function useRemoteAssetBaseState() {
diff --git a/app/middleware/admin-auth.ts b/app/middleware/admin-auth.ts
index 17c012d..d707200 100644
--- a/app/middleware/admin-auth.ts
+++ b/app/middleware/admin-auth.ts
@@ -6,7 +6,7 @@ export default defineNuxtRouteMiddleware(async (to) => {
     return redirectToLogin(to.fullPath);
   }
 
-  if (!profile.value.isAdmin) {
+  if (!profile.value?.isAdmin) {
     return navigateTo('/');
   }
 });
diff --git a/app/pages/admin/dashboard.vue b/app/pages/admin/dashboard.vue
index e520398..0cdd14f 100644
--- a/app/pages/admin/dashboard.vue
+++ b/app/pages/admin/dashboard.vue
@@ -15,7 +15,7 @@ const { profile } = useAuth();
 <template>
   <div class="w-full max-w-9xl mx-auto">
     <section class="sticky top-0 bg-white p-4 border-b border-zinc-200">
-      <div class="text-xl font-bold text-zinc-900 font-noto">👋🏽 Hello, {{ profile.firstName }}</div>
+      <div class="text-xl font-bold text-zinc-900 font-noto">👋🏽 Hello, {{ profile?.firstName }}</div>
       <div class="text-sm text-zinc-500">Track your hiring activities. You are almost there!</div>
       <div class="flex items-center mt-4">
         <InputButton as="NuxtLink" variant="secondary" to="/admin/postings/new">
diff --git a/server/api/userinfo.ts b/server/api/userinfo.ts
index 992950c..ce01e57 100644
--- a/server/api/userinfo.ts
+++ b/server/api/userinfo.ts
@@ -14,7 +14,8 @@ export default defineEventHandler(async (event) => {
 
     return session;
   } catch (e) {
-    if (IS_DEV) {
+    // @ts-expect-error
+    if (e.statusCode !== 401) {
       console.error(e);
     }
     throw e;