-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Laravel 6.x email rules #476
Comments
Looks like an outdated
It's only validating the input email against a regex - https://jqueryvalidation.org/email-method/ Support for
I've marked this as a feature request. |
It would be preferable if it could be implemented at JS level. That said, given the reliance on third-party PHP lib and differences in between PHP+JS regex implementations, I'm not sure what's worse, duplicating regexes into JS and having to maintain them (to keep up with the PHP lib), or having to make another AJAX request. The main motivation is to do with this lib is to do whats possible at JS level, otherwise it would be quite simple to just make all rules fire an AJAX request. |
Thanks @bytestream ! I guess it makes sense to do rfc validation on the client side since it's a standard so any differences between implementations should be seen as bugs on either side. As for the other rules, think it would make sense to do the AJAX requests since they're pretty much PHP lib specific, but it shouldn't be much of concern since the default email rule is rfc, so, by default, this lib wouldn't make those AJAX requests. |
Opening so I don't forget about this, details to come.
Basically if you have something like this in your
FormRequest.php
:The generated frontend code from this package doesn't attempt to validate to use other rules (such as dns and filter).
I guess the solution would be to make a request to the back end to validade this, but I just discovered this project today so I could be wrong :D.
The text was updated successfully, but these errors were encountered: