Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis-CI testing and Docker error? #101

Closed
jeremydouglass opened this issue Jun 7, 2017 · 3 comments
Closed

Travis-CI testing and Docker error? #101

jeremydouglass opened this issue Jun 7, 2017 · 3 comments

Comments

@jeremydouglass
Copy link
Member

I noticed that my changes are sometimes failing Travis-CI with this message:

The command "docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci" exited with 5.

e.g. here: https://travis-ci.org/gaocegege/Processing.R/builds/240249559?utm_source=github_status&utm_medium=notification

Why are we using docker here -- and is there anything in particular I should do about this in my local setup, or any particular cause?

@gaocegege
Copy link
Member

gaocegege commented Jun 7, 2017

We run coala check in Docker, so it is caused by coala: https://travis-ci.org/gaocegege/Processing.R/builds/240249559#L3654

The code is not in formatR format. But it doesn't matter, since I can fix these errors for you:-) If you have coala in your local env, just run coala and it has a option to apply the patches to fix these errors.

@jeremydouglass
Copy link
Member Author

Ah, I see, thank you. I was focusing on the docker part, and skimming over the coala reports because they were marked with [INFO] -- I see now that there are lots of small whitespace errors that are causing the check to fail, like t <- i / steps vs t <- i/steps.

I can install coala locally using docker. Very long term the best clean contribution solution for casual Processing.R authors will eventually to bind the CMD-T in PDE to a syntax cleanup, like in Java mode.

@gaocegege
Copy link
Member

Yeah, cmd T is helpful, and we have a issue: #84

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants