Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some methods have a weird signature #512

Open
sylvaincom opened this issue Oct 17, 2024 · 2 comments
Open

Some methods have a weird signature #512

sylvaincom opened this issue Oct 17, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@sylvaincom
Copy link
Contributor

Is your feature request related to a problem? Please describe.

from skore import load
project = load("project.skore")
project.put("my_int", 3)
print([method for method in dir(project) if callable(getattr(project, method)) and not method.startswith("__")])
project.put_item?

returns

Signature: project.put_item(key: str, item: skore.item.item.Item)

The skore.item.item.Item is quite weird.

Describe the solution you'd like

I would like something more concise?

Describe alternatives you've considered, if relevant

No response

Additional context

No response

@sylvaincom sylvaincom added enhancement New feature or request needs-triage This has been recently submitted and needs attention labels Oct 17, 2024
@tuscland tuscland removed the needs-triage This has been recently submitted and needs attention label Oct 18, 2024
@tuscland
Copy link
Member

It would be nice to make the packages more elegant. It surely looks weird to repeat item twice.

@rouk1
Copy link
Contributor

rouk1 commented Oct 18, 2024

Note that Item is aliased in its package __init__.py.

Hence you can use

from skore.item import Item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants