Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Ensure CLI is covered by test at 100% #508

Open
thomass-dev opened this issue Oct 16, 2024 · 2 comments
Open

chore: Ensure CLI is covered by test at 100% #508

thomass-dev opened this issue Oct 16, 2024 · 2 comments

Comments

@thomass-dev
Copy link
Collaborator

thomass-dev commented Oct 16, 2024 •
edited
Loading

Part of #475 , next step after #479 .

To be Windows-compliant, we need to ensure that all CLIs are executable.
@thomass-dev thomass-dev mentioned this issue Oct 16, 2024
Merged
rouk1 pushed a commit that referenced this issue Oct 16, 2024
@thomass-dev
feat(ci): Add windows support (#479)
004573c 
First step to resolve #475 .


![image](https://github.com/user-attachments/assets/43cfea0c-ae3b-44bf-83ff-8f03e64cbd21)

---

The tests can be run on Windows by enforcing the usage of the UTF-8
encoding using the
[PYTHONUTF8](https://docs.python.org/3/using/cmdline.html#envvar-PYTHONUTF8).
The next step should be to cover CLI 100%
(#508).
@thomass-dev
Copy link
Collaborator Author

thomass-dev commented Oct 16, 2024 •
edited
Loading

I've just create a branch to reference in #475 .

@sylvaincom
Copy link
Contributor

Thanks, let me know when I have to make changes to the README like adding instructions or adding a badge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/508-chore-ensure-cli-is-covered-by-test-at-100 probabl-ai/skore
2 participants
@thomass-dev @sylvaincom