Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Do not call .plot() when creating the display #1298

Closed
glemaitre opened this issue Feb 7, 2025 · 0 comments · Fixed by #1299
Closed

api: Do not call .plot() when creating the display #1298

glemaitre opened this issue Feb 7, 2025 · 0 comments · Fixed by #1299
Assignees
@glemaitre

Comments

@glemaitre
Copy link
Member

Following the changes in #1274, the display factory should not call internally .plot() and instead only return the display.
@glemaitre glemaitre self-assigned this Feb 7, 2025
@glemaitre glemaitre changed the title api: Do not call .plot() when creating the display. api: Do not call .plot() when creating the display Feb 7, 2025
@glemaitre glemaitre mentioned this issue Feb 7, 2025
Merged
@glemaitre glemaitre reopened this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glemaitre glemaitre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(api): Do not call .plot() in display factory glemaitre/skore
1 participant
@glemaitre