Skip to content

Create a project submodule for project related utilities #726

Closed Answered by thomass-dev
glemaitre asked this question in Q&A
Discussion options

You must be logged in to vote

Is there a rationale for not creating a project submodule. I find it a bit weird to have a cross_validate next to load that have nothing in common.

No, just an arbitrary choice and just a taste. I, too, prefer to store things in their dedicated directories.
Currently, the wrapper of the cross_validate function was moved to sklearn/. We think to split the module into several, it will probably be moved to sklearn/cross_validation/.

I vote +1 to move project.py in project/.

I would find it natural that cross_validate also leave in skore.model_selection if the goal is to mimic or minimize changes compare to the current scikit-learn code.

For that part, i'm not totally agree. We should kee…

Replies: 1 comment 1 reply

Comment options

You must be logged in to vote
1 reply
@MarieSacksick
Comment options

Answer selected by thomass-dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
3 participants