From e2305e91cdb1efb345b1992576f350d0900665f6 Mon Sep 17 00:00:00 2001 From: "Thomas S." Date: Mon, 7 Oct 2024 14:09:14 +0200 Subject: [PATCH 01/17] fix(readme): Fix badges (#444) To merge after #440 . ![image](https://github.com/user-attachments/assets/c14b4b8d-f562-434f-aa06-1d1c4fb2abf1) --- README.md | 5 ++--- skore/pyproject.toml | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 8e12397a..346f39f1 100644 --- a/README.md +++ b/README.md @@ -1,8 +1,7 @@ # skore -![lint](https://github.com/probabl-ai/skore/actions/workflows/lint.yml/badge.svg) -![tests](https://github.com/probabl-ai/skore/actions/workflows/backend.yml/badge.svg) -![UI tests](https://github.com/probabl-ai/skore/actions/workflows/skore-ui.yml/badge.svg) +![ci](https://github.com/probabl-ai/skore/actions/workflows/ci.yml/badge.svg) +![python](https://img.shields.io/badge/python-3.11%20|%203.12-blue?style=flat&logo=python) ## Installation diff --git a/skore/pyproject.toml b/skore/pyproject.toml index 97671891..d913bec0 100644 --- a/skore/pyproject.toml +++ b/skore/pyproject.toml @@ -3,6 +3,7 @@ name = "skore" description = "Tooling and assistance for data scientists to \"Own Your Data Science\"" dynamic = ["version"] readme = "README.md" +requires-python = ">=3.11" maintainers = [ {name = "skore developers", email="skore@signal.probabl.ai"}, ] From c97e0f8a8edc5b096df4c9d0dd3fd5aae4f69164 Mon Sep 17 00:00:00 2001 From: "Thomas S." Date: Mon, 7 Oct 2024 14:14:02 +0200 Subject: [PATCH 02/17] docs: Fix the skore description in PyPI (#445) --- .github/workflows/release.yml | 4 ++-- README.md | 6 +++--- skore/pyproject.toml | 2 -- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d9a63eea..c33291fc 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -65,7 +65,7 @@ jobs: path: skore/dist/ publish: - name: Publish package distributions to TestPyPI using trusted publisher + name: Publish package distributions to PyPI using trusted publisher runs-on: ubuntu-latest environment: release permissions: @@ -78,7 +78,7 @@ jobs: name: python-package-distributions path: dist/ - - name: Publish package distributions to TestPyPI + - name: Publish package distributions to PyPI uses: pypa/gh-action-pypi-publish@release/v1 with: verify-metadata: false diff --git a/README.md b/README.md index 346f39f1..c8d4d270 100644 --- a/README.md +++ b/README.md @@ -6,11 +6,11 @@ ## Installation For now, the only supported method to use skore is from source. -Follow the instructions in [CONTRIBUTING.md](/CONTRIBUTING.md#quick-start) to install dependencies and start the UI. +Follow the instructions in [CONTRIBUTING.md](https://github.com/probabl-ai/skore/blob/main/CONTRIBUTING.md#quick-start) to install dependencies and start the UI. ## Quick start -For a complete introductory example, see our [basic usage notebook](/examples/basic_usage.ipynb). The resulting skore report has been exported to [this HTML file](https://gist.github.com/augustebaum/6b21dbd7f7d5a584fbf2c1956692574e): download it and open it in your browser to visualize it. +For a complete introductory example, see our [basic usage notebook](https://github.com/probabl-ai/skore/blob/main/examples/basic_usage.ipynb). The resulting skore report has been exported to [this HTML file](https://gist.github.com/augustebaum/6b21dbd7f7d5a584fbf2c1956692574e): download it and open it in your browser to visualize it. In your shell, run the following to create a project file `project.skore` (the default) in your current working directory: ```sh @@ -75,4 +75,4 @@ In the future, you will be able to: ## Contributing -See [CONTRIBUTING.md](/CONTRIBUTING.md) for more information and to contribute to the evolution of this library. +See [CONTRIBUTING.md](https://github.com/probabl-ai/skore/blob/main/CONTRIBUTING.md) for more information and to contribute to the evolution of this library. diff --git a/skore/pyproject.toml b/skore/pyproject.toml index d913bec0..29afacc2 100644 --- a/skore/pyproject.toml +++ b/skore/pyproject.toml @@ -28,8 +28,6 @@ classifiers=[ "Operating System :: Unix", "Operating System :: MacOS", "Programming Language :: Python :: 3", - "Programming Language :: Python :: 3.9", - "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", "Programming Language :: Python :: 3.12" ] From 32baec4ece07d46f8b69802d11caa14ec1cf86c6 Mon Sep 17 00:00:00 2001 From: "Thomas S." Date: Mon, 7 Oct 2024 15:58:07 +0200 Subject: [PATCH 03/17] fix(Makefile): Fix missing LICENSE and README.md in `install-skore` (#447) --- Makefile | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Makefile b/Makefile index d71f17f1..ffbc4701 100644 --- a/Makefile +++ b/Makefile @@ -6,12 +6,18 @@ pip-compile: python -m piptools compile --extra=tools --output-file=skore/requirements-tools.txt skore/pyproject.toml install-skore: + cp LICENSE skore/LICENSE + cp README.md skore/README.md + python -m pip install \ -e skore/ \ -r skore/requirements.txt \ -r skore/requirements-test.txt \ -r skore/requirements-tools.txt + rm skore/LICENSE + rm skore/README.md + pre-commit install build-skore-ui: From 02510fc19151149c3bf948b0f8afed4b7db24276 Mon Sep 17 00:00:00 2001 From: "Matt J." Date: Mon, 7 Oct 2024 16:24:06 +0200 Subject: [PATCH 04/17] fix(UI): Add animation frames to plotly widgets (#448) --- skore-ui/src/components/PlotlyWidget.vue | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/skore-ui/src/components/PlotlyWidget.vue b/skore-ui/src/components/PlotlyWidget.vue index 9a17cebb..53a2ecc4 100644 --- a/skore-ui/src/components/PlotlyWidget.vue +++ b/skore-ui/src/components/PlotlyWidget.vue @@ -1,9 +1,9 @@ + +