Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double decryption on initial packets #1782

Open
rsepassi opened this issue Nov 22, 2024 · 1 comment
Open

Double decryption on initial packets #1782

rsepassi opened this issue Nov 22, 2024 · 1 comment

Comments

@rsepassi
Copy link

It seems that on initial connection, the server decrypts the initial client packet twice, once in picoquic_screen_initial_packet and once again in the normal flow. I can't think of a reason why this should be, so thought I'd flag it.

@huitema
Copy link
Collaborator

huitema commented Jan 19, 2025

It is complicated... When we create a new connection context, we need to compute the encryption and decryption keys for the "initial" context. The input processing did create a decryption key, but not the encryption key. It did however decrypt the packet, so there should be no need to decrypt it again -- we need to look at that in detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants