Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare UDP_COALESCED_INFO against cmsg_type not cmsg_level #1772

Closed
mxinden opened this issue Nov 9, 2024 · 1 comment
Closed

Compare UDP_COALESCED_INFO against cmsg_type not cmsg_level #1772

mxinden opened this issue Nov 9, 2024 · 1 comment

Comments

@mxinden
Copy link

mxinden commented Nov 9, 2024

As far as I can tell, UDP_COALESCED_INFO is a cmsg_type, not cmsg_level. The corresponding cmsg_level should be IPPROTO_UDP.

else if (cmsg->cmsg_level == UDP_COALESCED_INFO) {

See msquic implementation for reference:

https://github.com/microsoft/msquic/blob/c761886b3c3dfb09106584393b9c7580baca4c53/src/platform/datapath_winuser.c#L3215-L3221

Hope I am not missing something.

@huitema
Copy link
Collaborator

huitema commented Nov 10, 2024

@mxinden Thanks for finding that! The interesting part is that tests of the existing code were working, although maybe by chance. I have a fix in PR #1773, if you want to take a look.

@huitema huitema closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants