Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Add back valid tx check when the invalid tx feature is disabled #1740

Open
ChihChengLiang opened this issue Jan 22, 2024 · 0 comments
Open

Add back valid tx check when the invalid tx feature is disabled #1740

ChihChengLiang opened this issue Jan 22, 2024 · 0 comments
Labels
T-feature Type: new features

Comments

@ChihChengLiang
Copy link
Collaborator

Describe the feature you would like

#1677 moved the checks of matching nonce, sufficient gas limit, and sufficient balance to an InvalidTxGadget

After #1728 is completed. We'll need to consolidate the logic so that both valid and invalid tx are properly checked.

Additional context

No response
@ChihChengLiang ChihChengLiang added the T-feature Type: new features label Jan 22, 2024
@ChihChengLiang ChihChengLiang mentioned this issue Jan 22, 2024
Merged
2 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 31, 2024
@ChihChengLiang
Runtime config (#1728)
fc4964c 
### Description

We add an initial structure for runtime config. In this PR, we plan to
add only the invalid tx configuration for the starter.

### Issue Link

#1636 

### Type of change

New feature (non-breaking change which adds functionality)


### Decision

- Allow Geth to take invalid tx. The config doesn't affect geth util


### TODO

- [x] Fix invalid tx test
- [ ] Add tx validity check. (Will continue #1740)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T-feature Type: new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChihChengLiang