Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Meta: Refactor word_rlc into word hi/lo #1221

Closed
9 of 10 tasks
ed255 opened this issue Feb 17, 2023 · 3 comments
Closed
9 of 10 tasks

Meta: Refactor word_rlc into word hi/lo #1221

ed255 opened this issue Feb 17, 2023 · 3 comments
Milestone
word-hi-lo

Comments

@ed255
Copy link
Member

ed255 commented Feb 17, 2023 •
edited
Loading

Depends on the specs to be refactored privacy-scaling-explorations/zkevm-specs#216

Previous work needed:

Circuits:

This refactor requires updating many circuits and tests will probably not pass until everything is complete. For this reason we will work on this in a new branch, and we will submit PRs for these issues to this new branch. Once everything is in the branch we will work on making sure all tests pass and then merge it to main.
@ed255 ed255 added this to the word-hi-lo milestone Feb 17, 2023
@ed255
Copy link
Member Author

ed255 commented Apr 20, 2023

The spec refactor is now complete privacy-scaling-explorations/zkevm-specs#390
This issue is now unlocked. Since this will require touching every circuit my suggestion is to:

  • Wait until we have less open PRs
  • Split all the work into 3-5 people and do it in parallel, then merge it in a branch and make the PR.

@ed255 ed255 changed the title Refactor word_rlc into word hi/lo Meta: Refactor word_rlc into word hi/lo May 3, 2023
@ed255
Copy link
Member Author

ed255 commented May 30, 2023

CC has proposed a strategy that allows having the code building in the different stages of the refactor, and he has implemented it in this PR #1435 The approach consists on duplicating the types and functions that deal with words to have at the same time legacy and lo/hi versions, so that the refactor can be incremental and build at all times. Following this approach there's a list of duplicate types/functions that we will need to clean up before merging the word-lo-hi branch to main. This comments collects the details: #1435 (comment)

@ed255 ed255 mentioned this issue Jun 2, 2023
Open
@ed255
Copy link
Member Author

ed255 commented Jul 3, 2023

Marking this as complete via this PR #1504 which merged all the word lo/hi work to main!

The only remaining part now is updating the MPT to use word lo/hi, which is not yet in main.

@ed255 ed255 closed this as completed Jul 3, 2023
cameron1024 pushed a commit to cameron1024/zkevm-circuits that referenced this issue Jun 30, 2024
@lispc
testool: upgrade for cancun and other fixes (privacy-scaling-explorat…
a487780 
…ions#1221)

* wip

* update codehash

* done

* ok

* Reapply "feat: enable basefee opcode"

This reverts commit 4ba4f60.

* fix

* remove shanghai

* lint

* enable cancun and shanghai for l1 tracer

* fix 1559

* done
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
zkEVM Community Edition
Status: ✅ Done
Milestone
word-hi-lo
Development

No branches or pull requests
1 participant
@ed255