Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btw (out of scope of this PR), have you considered using an enum for this? #187

Closed
kalidiagne opened this issue Aug 20, 2024 · 2 comments
Closed

Comments

@kalidiagne
Copy link
Collaborator

          btw (out of scope of this PR), have you considered using an enum for this?
  projectStatus: ProjectStatus.Inactive,

which would be defined in @/lib/types

As a dev not familiar with this repo, I had to look for a project which I knew was inactive and check for its data to know what exact string to use. No big deal, but an enum would force doing the right thing automatically.

Originally posted by @sripwoud in #186 (comment)

@samajammin
Copy link
Member

Makes sense to me 👍

@kalidiagne kalidiagne mentioned this issue Sep 21, 2024
3 tasks
@kalidiagne
Copy link
Collaborator Author

Closing as is fixed by #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants