feat: lazy ot #186
feat: lazy ot #186
Conversation
|
LGTM, except one q above @sinui0 |
I dont see a q |
| }, | ||
| ); | ||
|
|
||
| while let Some(Queued { count, sender }) = self.queue.pop_front() { |
There was a problem hiding this comment.
if the sender payload length is less than what was queued, then there will be partial or empty OTReceiverOutput. Is this the intended behavior? why is such behavior needed?
seems like a footgun which will be hard to debug.
There was a problem hiding this comment.
The length of the entire queue gets processed at once, this should always have the correct number. The assumption is that new messages will not be queued in between transfers. This should probably be documented, or enforced via type state.
There was a problem hiding this comment.
@sinui0
Sorry, I'll try to more accurately describe the issue because your response didn't seem to address it.
Suppose, the receiver queues 60 OTs.
Suppose in receive the length of SenderPayload is 30.
Why is it not an error that the receiver will get only 30 OTs out of the 60 that they intended to receive?
This PR refactors our OT crates to have lazy interfaces. It also disposes of committed/verifiable functionality as we no longer need it. Dependent crates are in a broken state and will be fixed in following PRs. Ferret is also omitted temporarily.