Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TFHE #28

Open
enricobottazzi opened this issue Apr 21, 2024 · 6 comments
Open

Support TFHE #28

enricobottazzi opened this issue Apr 21, 2024 · 6 comments
Assignees

Comments

@enricobottazzi
Copy link
Member

TFHE still works on RLWE so it shouldn't be too hard to adapt it -> https://www.zama.ai/post/tfhe-deep-dive-part-1

@enricobottazzi enricobottazzi changed the title Extend it to support TFHE encryption scheme Support TFHE May 2, 2024
@adust09
Copy link

adust09 commented May 30, 2024

The back-end FHE primitives will be important👍

The purpose of this issue is to support multiple primitives, but what is the position of bfv-py ?

The readme says it is for educational purposes, but can we recognise this repository as an official BFV implementation in Greco?

@enricobottazzi
Copy link
Member Author

Hi @adust09. bfv-py is a very inefficient implementation of bfv algorithm that I made and that Greco happens to use for testing the whole flow. In particular, it is used to generate the inputs for the circuit. Any bfv backend should also be compatible with the existing circuit as long as you build some script (similar to this) to properly format the input and the parameters.

Not sure if this answers your question. What was your concern with bfv-py?

@adust09
Copy link

adust09 commented May 30, 2024

MAKE SENSE!
I personally found the implementation of bfv-py incomplete and wondered if it was a suitable backend for greco.For example, encording (currently only valid for sample_polynomial) and EvalMul are not implemented.So I wondered if there was a plan to replace them with other BFV implementations before TFHE.

@adust09
Copy link

adust09 commented May 30, 2024

btw, I've always wondered why it decrypts immediately after encrypting with circuit_sk without any operation (EvalAdd in bfv-py).I was satisfied with the explanation that this is also not directly related to the overall Greco flow test, so it is not executed.

@enricobottazzi
Copy link
Member Author

Exactly, you shouldn't see bfv-py as a backend, as there's really no backend needed here.

So I wondered if there was a plan to replace them with other BFV implementations before TFHE.

There's no particular priority here, it all depends if there's demand or willingness to contribute

@Vishalkulkarni45
Copy link

I would love to build the TFHE support for greco ,can i take this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants