Skip to content

Commit 22c8d5a

Browse files
henrik.lundinCommit bot
henrik.lundin
authored and
Commit bot
committed
Revert of Setting up an RTP input fuzzer for NetEq (patchset #2 id:20001 of https://codereview.webrtc.org/2315633002/ )
Reason for revert: Broke all Chromium libFuzzer builds https://bugs.chromium.org/p/chromium/issues/detail?id=645069 Original issue's description: > Setting up an RTP input fuzzer for NetEq > > This CL introduces a new fuzzer target neteq_rtp_fuzzer that > manipulates the RTP header fields before inserting the packets into > NetEq. A few helper classes are also introduced. > > BUG=webrtc:5447 > NOTRY=True > > Committed: https://crrev.com/2d273f1e97cd5030ed1686f27ce1118291b66395 > Cr-Commit-Position: refs/heads/master@{#14103} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5447 Review-Url: https://codereview.webrtc.org/2328483002 Cr-Commit-Position: refs/heads/master@{#14131}
1 parent 17e3fa1 commit 22c8d5a

File tree

7 files changed

+1
-313
lines changed

7 files changed

+1
-313
lines changed

webrtc/modules/audio_coding/BUILD.gn

-2
Original file line numberDiff line numberDiff line change
@@ -1110,8 +1110,6 @@ if (rtc_include_tests) {
11101110
"neteq/tools/audio_sink.h",
11111111
"neteq/tools/constant_pcm_packet_source.cc",
11121112
"neteq/tools/constant_pcm_packet_source.h",
1113-
"neteq/tools/encode_neteq_input.cc",
1114-
"neteq/tools/encode_neteq_input.h",
11151113
"neteq/tools/fake_decode_from_file.cc",
11161114
"neteq/tools/fake_decode_from_file.h",
11171115
"neteq/tools/input_audio_file.cc",

webrtc/modules/audio_coding/neteq/neteq.gypi

-2
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,6 @@
231231
'tools/audio_sink.cc',
232232
'tools/constant_pcm_packet_source.cc',
233233
'tools/constant_pcm_packet_source.h',
234-
'tools/encode_neteq_input.cc',
235-
'tools/encode_neteq_input.h',
236234
'tools/fake_decode_from_file.cc',
237235
'tools/fake_decode_from_file.h',
238236
'tools/input_audio_file.cc',

webrtc/modules/audio_coding/neteq/tools/encode_neteq_input.cc

-89
This file was deleted.

webrtc/modules/audio_coding/neteq/tools/encode_neteq_input.h

-64
This file was deleted.

webrtc/modules/audio_coding/neteq/tools/neteq_input.h

+1-3
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,7 @@ class NetEqInput {
6565
// time).
6666
virtual void AdvanceOutputEvent() = 0;
6767

68-
// Returns true if the source has come to an end. An implementation must
69-
// eventually return true from this method, or the test will end up in an
70-
// infinite loop.
68+
// Returns true if the source has come to an end.
7169
virtual bool ended() const = 0;
7270

7371
// Returns the RTP header for the next packet, i.e., the packet that will be

webrtc/test/fuzzers/BUILD.gn

-13
Original file line numberDiff line numberDiff line change
@@ -184,19 +184,6 @@ webrtc_fuzzer_test("audio_decoder_opus_redundant_fuzzer") {
184184
]
185185
}
186186

187-
webrtc_fuzzer_test("neteq_rtp_fuzzer") {
188-
sources = [
189-
"neteq_rtp_fuzzer.cc",
190-
]
191-
deps = [
192-
"../../modules/audio_coding:neteq",
193-
"../../modules/audio_coding:neteq_unittest_tools",
194-
"../../modules/audio_coding:pcm16b",
195-
"../../modules/rtp_rtcp",
196-
"../../test:test_support",
197-
]
198-
}
199-
200187
# TODO(katrielc) Enable in Chromium when CL 2022833002 lands.
201188
# Although the dependency on media compiles in standalone, it is
202189
# flagged by gn check, so breaks when rolled into Chromium.

webrtc/test/fuzzers/neteq_rtp_fuzzer.cc

-140
This file was deleted.

0 commit comments

Comments
 (0)